Make RefCountersImpl::SelfDestroy virtual to fix #704 (#705)

hzqst · web-flow · commit 7f79a92f191c · 2025-09-03T07:27:49.000-07:00
diff --git a/Common/interface/RefCountedObjectImpl.hpp b/Common/interface/RefCountedObjectImpl.hpp
@@ -43,7 +43,7 @@ namespace Diligent
 {
 
 // This class controls the lifetime of a refcounted object
-class RefCountersImpl final : public IReferenceCounters
+class RefCountersImpl : public IReferenceCounters
 {
 public:
     inline virtual ReferenceCounterValueType AddStrongRef() override final
@@ -448,12 +448,12 @@ class RefCountersImpl final : public IReferenceCounters
         }
     }
 
-    void SelfDestroy()
+    virtual void SelfDestroy()
     {
         delete this;
     }
 
-    ~RefCountersImpl()
+    virtual ~RefCountersImpl()
     {
         VERIFY(m_NumStrongReferences.load() == 0 && m_NumWeakReferences.load() == 0,
                "There exist outstanding references to the object being destroyed");

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ namespace Diligent`
`43`	`43`	`{`
`44`	`44`
`45`	`45`	`// This class controls the lifetime of a refcounted object`
`46`		`-class RefCountersImpl final : public IReferenceCounters`
	`46`	`+class RefCountersImpl : public IReferenceCounters`
`47`	`47`	`{`
`48`	`48`	`public:`
`49`	`49`	`inline virtual ReferenceCounterValueType AddStrongRef() override final`
`@@ -448,12 +448,12 @@ class RefCountersImpl final : public IReferenceCounters`
`448`	`448`	`}`
`449`	`449`	`}`
`450`	`450`
`451`		`- void SelfDestroy()`
	`451`	`+ virtual void SelfDestroy()`
`452`	`452`	`{`
`453`	`453`	`delete this;`
`454`	`454`	`}`
`455`	`455`
`456`		`- ~RefCountersImpl()`
	`456`	`+ virtual ~RefCountersImpl()`
`457`	`457`	`{`
`458`	`458`	`VERIFY(m_NumStrongReferences.load() == 0 && m_NumWeakReferences.load() == 0,`
`459`	`459`	`"There exist outstanding references to the object being destroyed");`