Skip to content

Commit 44e7612

Browse files
Add blueapi entry point
1 parent 3d52fce commit 44e7612

3 files changed

Lines changed: 28 additions & 8 deletions

File tree

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
from mx_bluesky.beamlines.i02_1.i02_1_gridscan_plan import i02_1_gridscan_plan
2+
3+
__all__ = ["i02_1_gridscan_plan"]

src/mx_bluesky/common/external_interaction/callbacks/common/ispyb_callback_base.py

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,12 +137,29 @@ def _handle_ispyb_hardware_read(self, doc) -> Sequence[ScanDataInfo]:
137137
)
138138
synchrotron_mode = _data["synchrotron-synchrotron_mode"]
139139
assert isinstance(synchrotron_mode, SynchrotronMode)
140-
hwscan_data_collection_info = DataCollectionInfo(
141-
undulator_gap1=_data["undulator-current_gap"],
142-
synchrotron_mode=synchrotron_mode.value,
143-
slitgap_horizontal=_data["s4_slit_gaps-xgap"],
144-
slitgap_vertical=_data["s4_slit_gaps-ygap"],
145-
)
140+
141+
# We should improve slit PV name to give consistency, or come up with a way
142+
# to get better typing on the _data dict
143+
if _data["s4_slit_gaps-xgap"]:
144+
hwscan_data_collection_info = DataCollectionInfo(
145+
undulator_gap1=_data["undulator-current_gap"],
146+
synchrotron_mode=synchrotron_mode.value,
147+
slitgap_horizontal=_data["s4_slit_gaps-xgap"],
148+
slitgap_vertical=_data["s4_slit_gaps-ygap"],
149+
)
150+
151+
elif _data["s4_slit_gaps-x_gap"]:
152+
hwscan_data_collection_info = DataCollectionInfo(
153+
undulator_gap1=_data["undulator-current_gap"],
154+
synchrotron_mode=synchrotron_mode.value,
155+
slitgap_horizontal=_data["s4_slit_gaps-x_gap"],
156+
slitgap_vertical=_data["s4_slit_gaps-y_gap"],
157+
)
158+
else:
159+
raise ValueError(
160+
f"Couldn't read slits from {doc=} and so couldn't update ispyb data collection info."
161+
)
162+
146163
hwscan_data_collection_info = _update_based_on_energy(
147164
doc, self.params.detector_params, hwscan_data_collection_info
148165
)

uv.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)