Refactor ColumnCollection ctor

Author: SergeiPavlov

Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs

@@ -1594,7 +1594,10 @@ private static ProjectionExpression CreateLocalCollectionProjectionExpression(Ty
     {
       var storedEntityType = translator.State.TypeOfEntityStoredInKey;
       var itemToTupleConverter = ItemToTupleConverter.BuildConverter(itemType, storedEntityType, value, translator.context.Model, sourceExpression);
-      var rsHeader = new RecordSetHeader(itemToTupleConverter.TupleDescriptor, itemToTupleConverter.TupleDescriptor.Select(x => new SystemColumn(translator.context.GetNextColumnAlias(), 0, x)).Cast<Column>());
+      var rsHeader = new RecordSetHeader(
+        itemToTupleConverter.TupleDescriptor,
+        itemToTupleConverter.TupleDescriptor.Select(x => new SystemColumn(translator.context.GetNextColumnAlias(), 0, x)).Cast<Column>().ToArray(itemToTupleConverter.TupleDescriptor.Count)
+      );
       var rawProvider = new RawProvider(rsHeader, itemToTupleConverter.GetEnumerable());
       var recordset = new StoreProvider(rawProvider);
       var itemProjector = new ItemProjectorExpression(itemToTupleConverter.Expression, recordset, translator.context);

Orm/Xtensive.Orm/Orm/Rse/ColumnCollection.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2007-2021 Xtensive LLC.
+// Copyright (C) 2007-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alexey Kochetov
@@ -89,7 +89,7 @@ internal Enumerator(IReadOnlyList<Column> list)
     /// <returns>The joined collection.</returns>
     public ColumnCollection Join(IEnumerable<Column> joined)
     {
-      return new ColumnCollection(this.Concat(joined));
+      return new ColumnCollection(this.Concat(joined).ToList());
     }
 
     /// <summary>
@@ -100,7 +100,7 @@ public ColumnCollection Join(IEnumerable<Column> joined)
     public ColumnCollection Alias(string alias)
     {
       ArgumentValidator.EnsureArgumentNotNullOrEmpty(alias, "alias");
-      return new ColumnCollection(this.Select(column => column.Clone(alias + "." + column.Name)));
+      return new ColumnCollection(this.Select(column => column.Clone(alias + "." + column.Name)).ToArray(Count));
     }
 
     /// <summary>
@@ -122,9 +122,9 @@ public ColumnCollection Alias(string alias)
     /// Initializes a new instance of this class.
     /// </summary>
     /// <param name="columns">Collection of items to add.</param>
-    public ColumnCollection(IEnumerable<Column> columns)
+    public ColumnCollection(IReadOnlyList<Column> columns)
     {
-      this.columns = columns as IReadOnlyList<Column> ?? columns.ToList();
+      this.columns = columns;
       var count = this.columns.Count;
       nameIndex = new Dictionary<string, int>(count);
       for (var index = count; index-- > 0;) {

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ContainsTableProvider.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2016-2020 Xtensive LLC.
+// Copyright (C) 2016-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 
@@ -74,7 +74,8 @@ public ContainsTableProvider(FullTextIndexInfo index, Func<ParameterContext, str
         var tupleDescriptor = TupleDescriptor.Create(fieldTypes);
         var columns = primaryIndexKeyColumns
           .Select((c, i) => (Column) new MappedColumn("KEY", i, c.Key.ValueType))
-          .Append(new MappedColumn("RANK", tupleDescriptor.Count, WellKnownTypes.Double));
+          .Append(new MappedColumn("RANK", tupleDescriptor.Count, WellKnownTypes.Double))
+          .ToArray(primaryIndexKeyColumns.Count + 1);;
         indexHeader = new RecordSetHeader(tupleDescriptor, columns);
       }
       Initialize();

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/FreeTextProvider.cs

@@ -67,7 +67,8 @@ public FreeTextProvider(
         var tupleDescriptor = TupleDescriptor.Create(fieldTypes);
         var columns = primaryIndexKeyColumns
           .Select((c, i) => (Column) new MappedColumn("KEY", i, c.Key.ValueType))
-          .Append(new MappedColumn("RANK", tupleDescriptor.Count, WellKnownTypes.Double));
+          .Append(new MappedColumn("RANK", tupleDescriptor.Count, WellKnownTypes.Double))
+          .ToArray(primaryIndexKeyColumns.Count + 1);
         indexHeader = new RecordSetHeader(tupleDescriptor, columns);
       }
       Initialize();

Orm/Xtensive.Orm/Orm/Rse/RecordSetHeader.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2007-2021 Xtensive LLC.
+// Copyright (C) 2007-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alexey Kochetov
@@ -181,7 +181,7 @@ public RecordSetHeader Select(IEnumerable<int> selectedColumns)
           .Select(o => new KeyValuePair<int, Direction>(columnsMap[o.Key], o.Value))
           .TakeWhile(o => o.Key >= 0));
 
-      var resultColumns = columns.Select((oldIndex, newIndex) => Columns[oldIndex].Clone(newIndex));
+      var resultColumns = columns.Select((oldIndex, newIndex) => Columns[oldIndex].Clone(newIndex)).ToArray(columns.Count);
 
       var resultGroups = ColumnGroups
         .Where(g => g.Keys.All(k => columnsMap[k]>=0))
@@ -251,7 +251,7 @@ private static RecordSetHeader CreateHeader(IndexInfo indexInfo)
         .ToArray(indexInfoKeyColumns.Count);
       var keyDescriptor = TupleDescriptor.Create(keyFieldTypes);
 
-      var resultColumns = indexInfoColumns.Select((c,i) => (Column) new MappedColumn(new ColumnInfoRef(c), i,c.ValueType));
+      var resultColumns = indexInfoColumns.Select((c,i) => (Column) new MappedColumn(new ColumnInfoRef(c), i,c.ValueType)).ToArray(indexInfoColumns.Count);
       var resultGroups = new[]{indexInfo.Group};
 
       return new RecordSetHeader(
@@ -278,7 +278,7 @@ public override string ToString()
     /// <param name="columns">Result columns.</param>
     public RecordSetHeader(
       TupleDescriptor tupleDescriptor,
-      IEnumerable<Column> columns)
+      IReadOnlyList<Column> columns)
       : this(tupleDescriptor, columns, null, null, null)
     {
     }
@@ -291,7 +291,7 @@ public RecordSetHeader(
     /// <param name="columnGroups">Column groups.</param>
     public RecordSetHeader(
       TupleDescriptor tupleDescriptor,
-      IEnumerable<Column> columns,
+      IReadOnlyList<Column> columns,
       IReadOnlyList<ColumnGroup> columnGroups)
       : this(tupleDescriptor, columns, columnGroups, null, null)
     {
@@ -306,7 +306,7 @@ public RecordSetHeader(
     /// <param name="order">Result sort order.</param>
     public RecordSetHeader(
       TupleDescriptor tupleDescriptor,
-      IEnumerable<Column> columns,
+      IReadOnlyList<Column> columns,
       TupleDescriptor orderKeyDescriptor,
       DirectionCollection<int> order)
       : this(tupleDescriptor, columns, null, orderKeyDescriptor, order)
@@ -324,7 +324,7 @@ public RecordSetHeader(
     /// <exception cref="ArgumentOutOfRangeException"><c>columns.Count</c> is out of range.</exception>
     public RecordSetHeader(
       TupleDescriptor tupleDescriptor,
-      IEnumerable<Column> columns,
+      IReadOnlyList<Column> columns,
       IReadOnlyList<ColumnGroup> columnGroups,
       TupleDescriptor orderKeyDescriptor,
       DirectionCollection<int> order)