Merge pull request #218 from DataObjects-NET/master-small-improvements

A bunch of small changes

Author: alex-kulakov

Orm/Xtensive.Orm.Tests/Xtensive.Orm.Tests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <AssemblySearchPaths>$(AssemblySearchPaths);{GAC}</AssemblySearchPaths>
@@ -29,21 +29,9 @@
     <ProjectReference Include="..\Xtensive.Orm\Xtensive.Orm.csproj" />
   </ItemGroup>
   <ItemGroup>
-    <None Update="Model\InterfaceAssociationsModelGenerator.tt">
-      <Generator>TextTemplatingFileGenerator</Generator>
-    </None>
     <None Update="Northwind.xml">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Update="Upgrade\HugeModelUpgrade\Models\ModelWithMappedTypes.tt">
-      <Generator>TextTemplatingFileGenerator</Generator>
-    </None>
-    <None Update="Upgrade\HugeModelUpgrade\Models\RegularModel.tt">
-      <Generator>TextTemplatingFileGenerator</Generator>
-    </None>
-    <None Update="Upgrade\HugeModelUpgrade\Models\TwoPartsModel.tt">
-      <Generator>TextTemplatingFileGenerator</Generator>
-    </None>
     <None Update="Chinook.xml">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

Orm/Xtensive.Orm/Orm/Providers/CommandProcessing/BatchingCommandProcessor.cs

@@ -15,7 +15,7 @@ namespace Xtensive.Orm.Providers
   internal sealed class BatchingCommandProcessor : CommandProcessor, ISqlTaskProcessor
   {
     private readonly int batchSize;
-    private Queue<SqlTask> tasks = new Queue<SqlTask>();
+    private Queue<SqlTask> tasks;
 
     void ISqlTaskProcessor.ProcessTask(SqlLoadTask task, CommandProcessorContext context)
     {
@@ -290,7 +290,7 @@ private void PutTasksForExecution(CommandProcessorContext context)
       }
       else {
         context.ProcessingTasks = tasks;
-        tasks = new Queue<SqlTask>();
+        tasks = new Queue<SqlTask>(batchSize);
       }
     }
 
@@ -328,6 +328,7 @@ public BatchingCommandProcessor(CommandFactory factory, int batchSize, int maxQu
     {
       ArgumentValidator.EnsureArgumentIsGreaterThan(batchSize, 1, nameof(batchSize));
       this.batchSize = batchSize;
+      this.tasks = new Queue<SqlTask>(batchSize);
     }
   }
 }

Orm/Xtensive.Orm/Orm/Providers/CommandProcessing/SimpleCommandProcessor.cs

@@ -14,7 +14,11 @@ namespace Xtensive.Orm.Providers
 {
   internal sealed class SimpleCommandProcessor : CommandProcessor, ISqlTaskProcessor
   {
-    private readonly Queue<SqlTask> tasks;
+    // equals to default batch size from SessionConfiguration
+    // hard to choose particular value so let it be some known number :)
+    private const int DefaultTaskQueueCapacity = 25;
+
+    private Queue<SqlTask> tasks = new(DefaultTaskQueueCapacity);
 
     void ISqlTaskProcessor.ProcessTask(SqlLoadTask task, CommandProcessorContext context)
     {
@@ -51,8 +55,8 @@ void ISqlTaskProcessor.ProcessTask(SqlPersistTask task, CommandProcessorContext
 
     public override void ExecuteTasks(CommandProcessorContext context)
     {
-      context.ProcessingTasks = new Queue<SqlTask>(tasks);
-      tasks.Clear();
+      context.ProcessingTasks = tasks;
+      tasks = new Queue<SqlTask>(DefaultTaskQueueCapacity);
 
       while (context.ProcessingTasks.Count > 0) {
         AllocateCommand(context);
@@ -79,8 +83,8 @@ public override void ExecuteTasks(CommandProcessorContext context)
 
     public override async Task ExecuteTasksAsync(CommandProcessorContext context, CancellationToken token)
     {
-      context.ProcessingTasks = new Queue<SqlTask>(tasks);
-      tasks.Clear();
+      context.ProcessingTasks = tasks;
+      tasks = new Queue<SqlTask>(DefaultTaskQueueCapacity);
 
       while (context.ProcessingTasks.Count > 0) {
         AllocateCommand(context);
@@ -152,7 +156,6 @@ private void ValidateCommandParameters(CommandPart commandPart)
     public SimpleCommandProcessor(CommandFactory factory, int maxQueryParameterCount)
       : base(factory, maxQueryParameterCount)
     {
-      tasks = new Queue<SqlTask>();
     }
   }
 }

Orm/Xtensive.Orm/Orm/QueryableExtensions.cs

@@ -42,7 +42,7 @@ public static IQueryable<TSource> Tag<TSource>(this IQueryable<TSource> source,
 
       var providerType = source.Provider.GetType();
       if (providerType != WellKnownOrmTypes.QueryProvider) {
-        var errorMessage = Strings.ExTakeDoesNotSupportQueryProviderOfTypeX;
+        var errorMessage = Strings.ExTagDoesNotSupportQueryProviderOfTypeX;
         throw new NotSupportedException(string.Format(errorMessage, providerType));
       }
 
@@ -66,7 +66,7 @@ public static IQueryable Tag(this IQueryable source, string tag)
 
       var providerType = source.Provider.GetType();
       if (providerType != WellKnownOrmTypes.QueryProvider) {
-        var errorMessage = Strings.ExTakeDoesNotSupportQueryProviderOfTypeX;
+        var errorMessage = Strings.ExTagDoesNotSupportQueryProviderOfTypeX;
         throw new NotSupportedException(string.Format(errorMessage, providerType));
       }
 

Orm/Xtensive.Orm/Orm/Rse/ColumnCollection.cs

@@ -122,8 +122,16 @@ public ColumnCollection Alias(string alias)
     /// Initializes a new instance of this class.
     /// </summary>
     /// <param name="columns">Collection of items to add.</param>
+    /// <remarks>
+    /// <paramref name="columns"/> is used to initialize inner field directly
+    /// to save time on avoiding collection copy. If you pass an <see cref="IReadOnlyList{Column}"/>
+    /// implementor that, in fact, can be changed, make sure the passed collection doesn't change afterwards.
+    /// Ideally, use arrays instead of <see cref="List{T}"/> or similar collections.
+    /// Changing the passed collection afterwards will lead to unpredictable results.
+    /// </remarks>
     public ColumnCollection(IReadOnlyList<Column> columns)
     {
+      //!!! Direct initialization by parameter is unsafe performance optimization: See remarks in ctor summary!
       this.columns = columns;
       var count = this.columns.Count;
       nameIndex = new Dictionary<string, int>(count);

Orm/Xtensive.Orm/Orm/Rse/ColumnGroupCollection.cs

@@ -55,8 +55,16 @@ public static ColumnGroupCollection Empty {
     /// Initializes a new instance of this class.
     /// </summary>
     /// <param name="items">The collection items.</param>
+    /// <remarks>
+    /// <paramref name="items"/> is used to initialize inner field directly
+    /// to save time on avoiding collection copy. If you pass an <see cref="IReadOnlyList{ColumnGroup}"/>
+    /// implementor that, in fact, can be changed, make sure the passed collection doesn't change afterwards.
+    /// Ideally, use arrays instead of <see cref="List{T}"/> or similar collections.
+    /// Changing the passed collection afterwards will lead to unpredictable results.
+    /// </remarks>
     public ColumnGroupCollection(IReadOnlyList<ColumnGroup> items)
     {
+      //!!! Direct initialization by parameter is unsafe performance optimization: See remark in ctor summary!
       this.items = items;
     }
   }