Minor changes in main project

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Configuration/DomainConfiguration.cs

@@ -877,7 +877,7 @@ private static DomainConfiguration LoadConfigurationFromSection(ConfigurationSec
     /// </summary>
     /// <param name="configurationSection">Root configuration section where domain configurations are placed</param>
     /// <param name="name">Name of the <see cref="Domain"/>.</param>
-    /// <returns></returns>
+    /// <returns>Domain configuration.</returns>
     /// <exception cref="InvalidOperationException">The "domains" section is not found or domain with requested name is not found.</exception>
     public static DomainConfiguration Load(IConfigurationSection configurationSection, string name)
     {

Orm/Xtensive.Orm/Orm/Configuration/Internals/ConfigurationSectionExtensions.cs

@@ -1,8 +1,9 @@
-using System;
+// Copyright (C) 2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using Microsoft.Extensions.Configuration;
 using Xtensive.Collections;
 

Orm/Xtensive.Orm/Orm/Configuration/LoggingConfiguration.cs

@@ -7,7 +7,9 @@
 using System;
 using System.Collections.Generic;
 using System.Configuration;
+using Microsoft.Extensions.Configuration;
 using Xtensive.Core;
+using Xtensive.Orm.Configuration.Internals;
 using ConfigurationSection = Xtensive.Orm.Configuration.Elements.ConfigurationSection;
 
 namespace Xtensive.Orm.Configuration
@@ -43,7 +45,7 @@ public static LoggingConfiguration Load()
     /// <returns>Loaded configuration.</returns>
     public static LoggingConfiguration Load(string sectionName)
     {
-      ArgumentValidator.EnsureArgumentNotNullOrEmpty(sectionName, "sectionName");
+      ArgumentValidator.EnsureArgumentNotNullOrEmpty(sectionName, nameof(sectionName));
 
       var section = (ConfigurationSection)ConfigurationManager.GetSection(sectionName);
       if (section==null)
@@ -70,8 +72,8 @@ public static LoggingConfiguration Load(System.Configuration.Configuration confi
     /// <returns>Loaded configuration.</returns>
     public static LoggingConfiguration Load(System.Configuration.Configuration configuration, string sectionName)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configuration, "configuration");
-      ArgumentValidator.EnsureArgumentNotNullOrEmpty(sectionName, "sectionName");
+      ArgumentValidator.EnsureArgumentNotNull(configuration, nameof(configuration));
+      ArgumentValidator.EnsureArgumentNotNullOrEmpty(sectionName, nameof(sectionName));
 
       var section = (ConfigurationSection) configuration.GetSection(sectionName);
       if (section==null)
@@ -80,12 +82,36 @@ public static LoggingConfiguration Load(System.Configuration.Configuration confi
       return loggingConfiguration;
     }
 
+    /// <summary>
+    /// Loads logging configuration from the specified configuration section.
+    /// </summary>
+    /// <param name="configurationSection">Root configuration section where logging configuration is placed.</param>
+    /// <returns>Logging configuration.</returns>
+    /// <exception cref="InvalidOperationException">The logging section is not found.</exception>
     public static LoggingConfiguration Load(IConfigurationSection configurationSection)
     {
       return new LoggingConfigurationReader().Read(configurationSection);
     }
 
+    /// <summary>
+    /// Loads logging configuration from default section.
+    /// </summary>
+    /// <param name="configurationRoot">Root of configuration.</param>
+    /// <returns>Read configuration.</returns>
+    /// <exception cref="InvalidOperationException">The logging section is not found.</exception>
+    public static LoggingConfiguration Load(IConfigurationRoot configurationRoot)
+    {
       return new LoggingConfigurationReader().Read(configurationRoot);
+    }
+
+    /// <summary>
+    /// Loads logging configuration from specific section.
+    /// </summary>
+    /// <param name="configurationRoot">Root of configuration.</param>
+    /// <param name="sectionName">Section name where logging configuration is defined.</param>
+    /// <returns>Read configuration.</returns>
+    /// <exception cref="InvalidOperationException">The logging section is not found.</exception>
+    public static LoggingConfiguration Load(IConfigurationRoot configurationRoot, string sectionName)
     {
       return new LoggingConfigurationReader().Read(configurationRoot, sectionName);
     }

Orm/Xtensive.Orm/Orm/Configuration/Options/DomainConfigurationOptions.cs

@@ -301,19 +301,11 @@ public DomainConfiguration ToNative(IDictionary<string, string> connectionString
         }
       }
 
-      foreach (var element in Sessions)
+      foreach (var element in Sessions) {
         config.Sessions.Add(element.Value.ToNative(connectionStrings));
+      }
 
       return config;
     }
-
-    private static T ParseEnum<T>(string value)
-      where T : struct
-    {
-      if (!Enum.TryParse<T>(value, true, out var result)) {
-        throw new ArgumentException($"Can't parse given value '{value}' to enum type '{typeof(T).FullName}'");
-      }
-      return result;
-    }
   }
 }

Orm/Xtensive.Orm/Orm/Configuration/Options/IgnoreRuleOptions.cs

@@ -13,17 +13,37 @@ internal sealed class IgnoreRuleOptions : IIdentifyableOptions,
     IValidatableOptions,
     IToNativeConvertable<IgnoreRule>
   {
+    /// <inheritdoc/>
     public object Identifier =>
       (Database ?? string.Empty,
        Schema ?? string.Empty,
        Table ?? string.Empty,
        Column ?? string.Empty,
        Index ?? string.Empty);
 
+    /// <summary>
+    /// Database part of the rule
+    /// </summary>
     public string Database { get; set; }
+
+    /// <summary>
+    /// Schema part of the rule.
+    /// </summary>
     public string Schema { get; set; }
+
+    /// <summary>
+    /// Table part of the rule.
+    /// </summary>
     public string Table { get; set; }
+
+    /// <summary>
+    /// Column part of the rule.
+    /// </summary>
     public string Column { get; set; }
+
+    /// <summary>
+    /// Index part of the rule.
+    /// </summary>
     public string Index { get; set; }
 
     /// <inheritdoc />