Merge branch 'master' into upstream/covariantReturnTypes

Author: SergeiPavlov

ChangeLog/7.2.0-Beta-1-dev.txt

@@ -0,0 +1,12 @@
+[main] Unused Xtensive.Collections.PriorityQueue is removed
+[main] Xtensive.Orm.Rse.Providers.Provider.Sources has changed return type to IReadOnlyList<T>, as well as ctor parameter
+[main] SqlInsert.Values became obsolete and no longer in use. Use ValueRows collection to add value rows
+[main] DomainConfiguration.MaxNumberOfConditions is introduced
+[main] SqlDml.Truncate() is introduced.
+[main] WellKnown.MaxNumberOfConditions became obsolete, use new DomainConfiguration.MaxNumberOfConditions if needed
+[main] Temporary tables cleanup now uses TRUNCATE instead of DELETE when possible
+[main] Temporary tables population is increased with multi-row inserts - 256 and 16 items per INSERT
+[main] PersistParameterBinding has new field RowIndex, use it for multi-row inserts if needed
+[main] TemporaryTableDescriptor changed interface to IMultiRecordPersistDescriptor, fully compatible with IPersistDescriptor
+[postgresql] QueryInfo.MaxQueryParameterCount actualized, it is 65535 now
+[oracle] QueryInfo.MaxQueryParameterCount actualized, it is 65535 now

Orm/Xtensive.Orm.Oracle/Sql.Drivers.Oracle/v09/ServerInfoProvider.cs

@@ -183,7 +183,7 @@ public override QueryInfo GetQueryInfo()
       queryInfo.ParameterPrefix = ":";
       queryInfo.MaxLength = DoNotKnow;
       queryInfo.MaxComparisonOperations = DoNotKnow;
-      queryInfo.MaxQueryParameterCount = 63999;
+      queryInfo.MaxQueryParameterCount = 65535;
       queryInfo.Features =
         QueryFeatures.NamedParameters |
         QueryFeatures.ParameterPrefix |
@@ -202,7 +202,8 @@ public override ServerFeatures GetServerFeatures()
       return ServerFeatures.Savepoints |
         ServerFeatures.LargeObjects |
         ServerFeatures.CursorParameters |
-        ServerFeatures.MultipleResultsViaCursorParameters;
+        ServerFeatures.MultipleResultsViaCursorParameters |
+        ServerFeatures.TemporaryTableEmulation;
     }
 
     public override IdentityInfo GetIdentityInfo()

Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v9_0/ServerInfoProvider.cs

@@ -10,6 +10,13 @@ namespace Xtensive.Sql.Drivers.PostgreSql.v9_0
 {
   internal class ServerInfoProvider : v8_4.ServerInfoProvider
   {
+    public override QueryInfo GetQueryInfo()
+    {
+      var queryInfo = base.GetQueryInfo();
+      queryInfo.MaxQueryParameterCount = 65535;
+      return queryInfo;
+    }
+
     // Constructors
 
     public ServerInfoProvider(SqlDriver driver)

Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/DriverFactory.cs

@@ -44,7 +44,8 @@ private static ErrorMessageParser CreateMessageParser(SqlServerConnection connec
       bool isEnglish;
       using (var command = connection.CreateCommand()) {
         command.CommandText = LangIdQuery;
-        isEnglish = command.ExecuteScalar().ToString()=="0";
+        var langId = (short) command.ExecuteScalar();
+        isEnglish = langId == 0 || langId == 23;
       }
 
       var templates = new Dictionary<int, string>();

Orm/Xtensive.Orm.Tests.Core/Collections/PriorityQueueTest.cs

@@ -32,6 +32,9 @@
 
     <domain name="mssql2019"
             connectionUrl="sqlserver://localhost\DO_SQL2019/DO-Tests?MultipleActiveResultSets=True" />
+    
+    <domain name="mssql2022"
+            connectionUrl="sqlserver://localhost\DO_SQL2022/DO-Tests?MultipleActiveResultSets=True" />
 
     <domain name="pgsql83"
             connectionUrl="postgresql://dotest:dotest@localhost:5483/dotest" />
@@ -66,6 +69,9 @@
     <domain name="pgsql140"
             connectionUrl="postgresql://dotest:dotest@localhost:54140/dotest" />
 
+    <domain name="pgsql150"
+            connectionUrl="postgresql://dotest:dotest@localhost:54150/dotest" />
+
     <domain name="oracle10"
             connectionUrl="oracle://dotest:dotest@localhost:5510/ora10" />
 
@@ -122,6 +128,9 @@
     <domain name="mssql2019cs" provider="sqlserver"
             connectionString="Data Source=localhost\DO_SQL2019;Initial Catalog=DO-Tests;Integrated Security=True;MultipleActiveResultSets=True" />
 
+    <domain name="mssql2022cs" provider="sqlserver"
+            connectionString="Data Source=localhost\DO_SQL2022;Initial Catalog=DO-Tests;Integrated Security=True;MultipleActiveResultSets=True" />
+
     <domain name="pgsql83cs" provider="postgresql"
             connectionString="HOST=localhost;PORT=5483;DATABASE=dotest;USER ID=dotest;PASSWORD=dotest" />
 
@@ -155,6 +164,9 @@
     <domain name="pgsql140cs" provider="postgresql"
             connectionString="HOST=localhost;PORT=54140;DATABASE=dotest;USER ID=dotest;PASSWORD=dotest" />
 
+    <domain name="pgsql150cs" provider="postgresql"
+            connectionString="HOST=localhost;PORT=54150;DATABASE=dotest;USER ID=dotest;PASSWORD=dotest" />
+
     <domain name="oracle10cs" provider="oracle"
             connectionString="DATA SOURCE=&quot;(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=localhost)(PORT=5510))(CONNECT_DATA=(SERVICE_NAME=ora10)))&quot;;USER ID=dotest;PASSWORD=dotest" />
 

Orm/Xtensive.Orm.Tests.Framework/Orm.config

@@ -169,6 +169,7 @@ public static TimeOnly AdjustTimeOnlyForProvider(this TimeOnly origin, StoragePr
       var newTicks = ticks - (ticks % divider.Value);
       return new TimeOnly(newTicks);
     }
+#endif
 
     public static void AddValueRow(this SqlInsert insert, in (SqlColumn column, SqlExpression value) first, params (SqlColumn column, SqlExpression value)[] additional)
     {
@@ -180,6 +181,5 @@ public static void AddValueRow(this SqlInsert insert, in (SqlColumn column, SqlE
       }
       insert.ValueRows.Add(row);
     }
-#endif
   }
 }

Orm/Xtensive.Orm.Tests.Framework/TestHelper.cs

@@ -0,0 +1,61 @@
+// Copyright (C) 2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
+using System;
+using NUnit.Framework;
+
+namespace Xtensive.Orm.Tests.Configuration
+{
+  [TestFixture]
+  public class MaxNumberOfConditionsTest
+  {
+    [Test]
+    public void NegativeNumberTest()
+    {
+      var config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = -1;
+      _ = Assert.Throws<InvalidOperationException>(() => config.Lock());
+
+      config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = -100;
+      _ = Assert.Throws<InvalidOperationException>(() => config.Lock());
+    }
+
+    [Test]
+    public void MaxNumberIsZeroTest()
+    {
+      var config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = 0;
+      _ = Assert.Throws<InvalidOperationException>(() => config.Lock());
+    }
+
+    [Test]
+    public void MaxNumberIsOneTest()
+    {
+      var config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = 1;
+      _ = Assert.Throws<InvalidOperationException>(() => config.Lock());
+    }
+
+    [Test]
+    public void EdgeValuesTest()
+    {
+      var config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = 2;
+      Assert.DoesNotThrow(() => config.Lock());
+
+      config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = 999;
+      Assert.DoesNotThrow(() => config.Lock());
+    }
+
+    [Test]
+    public void ExceededLimit()
+    {
+      var config = DomainConfigurationFactory.Create();
+      config.MaxNumberOfConditions = 1000;
+      _ = Assert.Throws<InvalidOperationException>(() => config.Lock());
+    }
+  }
+}