Remove remaining argument checks in providers hierarchy

Author: AlexUstinov

Directory.Build.props

@@ -41,7 +41,7 @@
     <NoLogo>true</NoLogo>
     <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
     <TargetFramework>net6.0</TargetFramework>
-    <LangVersion>9.0</LangVersion>
+    <LangVersion>10.0</LangVersion>
     <SolutionDir Condition="$(SolutionDir) == ''">$([MSBuild]::EnsureTrailingSlash(
       $([MSBuild]::GetDirectoryNameOfFileAbove('$(MSBuildThisFileDirectory)', 'Orm.sln'))))</SolutionDir>
     <Configuration Condition="$(Configuration) == ''">Debug</Configuration>

Orm/Xtensive.Orm/Core/PreconditionValidator.cs

@@ -0,0 +1,18 @@
+using System;
+using System.Diagnostics.CodeAnalysis;
+using System.Runtime.CompilerServices;
+
+internal static class PreconditionValidator
+{
+    [return: NotNull]
+    public static T NotNull<T>(
+        [NotNull] this T obj,
+        string message = default,
+        [CallerArgumentExpression("obj")]
+        string parameterName = default)
+        where T : class
+    {
+        return obj ?? throw new ArgumentNullException(parameterName, message);
+    }
+
+}

Orm/Xtensive.Orm/Orm/Providers/SqlProvider.cs

@@ -4,7 +4,6 @@
 // Created by: Alexey Kochetov
 // Created:    2008.07.11
 
-using System.Linq;
 using Xtensive.Core;
 using Xtensive.Sql;
 using Xtensive.Sql.Dml;
@@ -21,30 +20,17 @@ public class SqlProvider : ExecutableProvider
   {
     protected readonly HandlerAccessor handlers;
 
-    private const string ParameterNamePrefix = "@p";
-    private const string ToStringFormat = "[Command: \"{0}\"]";
     private SqlTable permanentReference;
 
     /// <summary>
     /// Gets <see cref="QueryRequest"/> associated with this provider.
     /// </summary>
-    public QueryRequest Request { get; private set; }
+    public QueryRequest Request { get; }
 
     /// <summary>
     /// Gets the permanent reference (<see cref="SqlQueryRef"/>) for <see cref="SqlSelect"/> associated with this provider.
     /// </summary>
-    public SqlTable PermanentReference {
-      get {
-        if (ReferenceEquals(null, permanentReference))
-          permanentReference = SqlDml.QueryRef(Request.Statement);
-        return permanentReference;
-      }
-    }
-
-    /// <summary>
-    /// Gets the domain handler this provider is bound to.
-    /// </summary>
-    protected Providers.DomainHandler DomainHandler { get { return handlers.DomainHandler; } }
+    public SqlTable PermanentReference => permanentReference ??= SqlDml.QueryRef(Request.Statement);
 
     /// <inheritdoc/>
     protected internal override DataReader OnEnumerate(Rse.Providers.EnumerationContext context)

Orm/Xtensive.Orm/Orm/Providers/SqlTemporaryDataProvider.cs

@@ -7,7 +7,6 @@
 using System;
 using Xtensive.Core;
 using System.Collections.Generic;
-using Xtensive.Tuples;
 using Tuple = Xtensive.Tuples.Tuple;
 using Xtensive.Orm.Rse.Providers;
 
@@ -25,7 +24,7 @@ public abstract class SqlTemporaryDataProvider : SqlProvider
     protected void LockAndStore(Rse.Providers.EnumerationContext context, IEnumerable<Tuple> data)
     {
       var storageContext = (EnumerationContext) context;
-      var tableLock = DomainHandler.TemporaryTableManager.Acquire(storageContext, tableDescriptor);
+      var tableLock = handlers.DomainHandler.TemporaryTableManager.Acquire(storageContext, tableDescriptor);
       if (tableLock == null) 
         return;
       storageContext.SetValue(this, TemporaryTableLockName, tableLock);

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/BinaryProvider.cs

@@ -51,9 +51,6 @@ protected BinaryProvider(ProviderType type, CompilableProvider left, CompilableP
     protected BinaryProvider(ProviderType type, RecordSetHeader header, CompilableProvider left, CompilableProvider right)
       : base(type, header, left, right)
     {
-      ArgumentValidator.EnsureArgumentNotNull(header, nameof(header));
-      ArgumentValidator.EnsureArgumentNotNull(left, nameof(left));
-      ArgumentValidator.EnsureArgumentNotNull(right, nameof(right));
       Left = left;
       Right = right;
     }

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ExceptProvider.cs

@@ -22,9 +22,6 @@ public sealed class ExceptProvider : BinaryProvider
 
     private static RecordSetHeader BuildHeader(CompilableProvider left, CompilableProvider right)
     {
-      ArgumentValidator.EnsureArgumentNotNull(left, nameof(left));
-      ArgumentValidator.EnsureArgumentNotNull(right, nameof(right));
-
       var leftHeader = left.Header;
       var leftDescriptor = leftHeader.TupleDescriptor;
       var rightDescriptor = right.Header.TupleDescriptor;

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/FilterProvider.cs

@@ -20,31 +20,17 @@ namespace Xtensive.Orm.Rse.Providers
   [Serializable]
   public sealed class FilterProvider : UnaryProvider
   {
-    private Func<Tuple, bool> compiledPredicate;
-
     /// <summary>
     /// Filtering predicate expression.
     /// </summary>
-    public Expression<Func<Tuple, bool>> Predicate { get; private set; }
-
-    /// <summary>
-    /// Gets the compiled <see cref="Predicate"/>.
-    /// </summary>
-    public Func<Tuple, bool> CompiledPredicate {
-      get {
-        if (compiledPredicate==null)
-          compiledPredicate = Predicate.CachingCompile();
-        return compiledPredicate;
-      }
-    }
+    public Expression<Func<Tuple, bool>> Predicate { get; }
 
     /// <inheritdoc/>
     protected override string ParametersToString()
     {
       return Predicate.ToString(true);
     }
 
-
     // Constructors
 
     /// <summary>

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IncludeProvider.cs

@@ -58,10 +58,6 @@ public sealed class IncludeProvider: UnaryProvider,
     private static RecordSetHeader BuildHeaderAndFilteredTupleDescriptor(
       CompilableProvider source, IReadOnlyList<int> filteredColumns, string resultColumnName, out TupleDescriptor filteredTupleDescriptor)
     {
-      ArgumentValidator.EnsureArgumentNotNull(source, nameof(source));
-      ArgumentValidator.EnsureArgumentNotNull(filteredColumns, nameof(filteredColumns));
-      ArgumentValidator.EnsureArgumentNotNullOrEmpty(resultColumnName, nameof(resultColumnName));
-
       var header = source.Header.Add(new SystemColumn(resultColumnName, 0, WellKnownTypes.Bool));
       var columnCount = filteredColumns.Count;
       var fieldTypes = new Type[columnCount];
@@ -85,7 +81,6 @@ public IncludeProvider(CompilableProvider source, IncludeAlgorithm algorithm, bo
       Expression<Func<ParameterContext, IEnumerable<Tuple>>> filterDataSource, string resultColumnName, IReadOnlyList<int> filteredColumns)
       : base(ProviderType.Include, BuildHeaderAndFilteredTupleDescriptor(source, filteredColumns, resultColumnName, out var filteredTupleDescriptor), source)
     {
-      ArgumentValidator.EnsureArgumentNotNull(filterDataSource, nameof(FilterDataSource));
       Algorithm = algorithm;
       IsInlined = isInlined;
       FilterDataSource = filterDataSource;

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IntersectProvider.cs

@@ -17,14 +17,10 @@ namespace Xtensive.Orm.Rse.Providers
   public sealed class IntersectProvider : BinaryProvider
   {
 
-
     // Constructors
 
     private static RecordSetHeader BuildHeader(CompilableProvider left, CompilableProvider right)
     {
-      ArgumentValidator.EnsureArgumentNotNull(left, nameof(left));
-      ArgumentValidator.EnsureArgumentNotNull(right, nameof(right));
-
       var leftHeader = left.Header;
       var leftDescriptor = leftHeader.TupleDescriptor;
       var rightDescriptor = right.Header.TupleDescriptor;

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/RawProvider.cs

@@ -25,18 +25,12 @@ public sealed class RawProvider : CompilableProvider
     /// <summary>
     /// Raw data source - an array of tuples.
     /// </summary>
-    public Expression<Func<ParameterContext, IEnumerable<Tuple>>> Source { get; private set; }
+    public Expression<Func<ParameterContext, IEnumerable<Tuple>>> Source { get; }
 
     /// <summary>
     /// Gets the compiled <see cref="Source"/>.
     /// </summary>
-    public Func<ParameterContext, IEnumerable<Tuple>> CompiledSource {
-      get {
-        if (compiledSource==null)
-          compiledSource = Source.CachingCompile();
-        return compiledSource;
-      }
-    }
+    public Func<ParameterContext, IEnumerable<Tuple>> CompiledSource => compiledSource ??= Source.CachingCompile();
 
     /// <inheritdoc/>
     protected override string ParametersToString()