Skip to content

Commit 52f82f0

Browse files
committed
Firebird: Fix tests in Issues group
- add requirements to test cases which is not supposed to be run on firebird due to lack of support of ceratain features - workaround for certain test cases to have correct expected results - formatting
1 parent 30b9329 commit 52f82f0

5 files changed

Lines changed: 83 additions & 61 deletions

Orm/Xtensive.Orm.Tests/Issues/Issue0624_EntitySetSubqueryError.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public class Issue0624_EntitySetSubqueryError : AutoBuildTest
6969
{
7070
protected override void CheckRequirements()
7171
{
72-
base.CheckRequirements();
7372
Require.ProviderIsNot(StorageProvider.Oracle | StorageProvider.MySql);
7473
}
7574

@@ -102,6 +101,8 @@ public void Test01()
102101
[Test]
103102
public void Test02()
104103
{
104+
Require.AnyFeatureSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
105+
105106
using (var session = Domain.OpenSession())
106107
using (var t = session.OpenTransaction()) {
107108
var controlId = Guid.NewGuid();

Orm/Xtensive.Orm.Tests/Issues/IssueJira0437_OperationsWithListOfInt.cs

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
// Copyright (C) 2013 Xtensive LLC.
2-
// All rights reserved.
3-
// For conditions of distribution and use, see license.
1+
// Copyright (C) 2013-2021 Xtensive LLC.
2+
// This code is distributed under MIT license terms.
3+
// See the License.txt file in the project root for more information.
44
// Created by: Denis Krjuchkov
55
// Created: 2013.02.22
66

@@ -35,21 +35,24 @@ protected override DomainConfiguration BuildConfiguration()
3535
return configuration;
3636
}
3737

38+
protected override void CheckRequirements()
39+
=> Require.AnyFeatureSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
40+
3841
protected override void PopulateData()
3942
{
4043
using (var session = Domain.OpenSession())
4144
using (var tx = session.OpenTransaction()) {
42-
new NamedObject {Name = "One"};
43-
new NamedObject {Name = "Two"};
44-
new NamedObject {Name = "Three"};
45+
_ = new NamedObject {Name = "One"};
46+
_ = new NamedObject {Name = "Two"};
47+
_ = new NamedObject {Name = "Three"};
4548
tx.Complete();
4649
}
4750
}
4851

4952
[Test]
5053
public void GroupJoinTest()
5154
{
52-
Require.AnyFeatureNotSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
55+
Require.AnyFeatureSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
5356
using (var session = Domain.OpenSession())
5457
using (var tx = session.OpenTransaction()) {
5558
var items = new List<int> {2, 3};
@@ -66,7 +69,7 @@ into j
6669
[Test]
6770
public void JoinTest()
6871
{
69-
Require.AnyFeatureNotSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
72+
Require.AnyFeatureSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
7073
using (var session = Domain.OpenSession())
7174
using (var tx = session.OpenTransaction()) {
7275
var items = new List<int> {1, 2};
@@ -87,7 +90,7 @@ orderby o.Id
8790
[Test]
8891
public void ApplyTest()
8992
{
90-
Require.AnyFeatureNotSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
93+
Require.AnyFeatureSupported(ProviderFeatures.TemporaryTableEmulation | ProviderFeatures.TemporaryTables);
9194
using (var session = Domain.OpenSession())
9295
using (var tx = session.OpenTransaction()) {
9396
var items = new List<int> {1, 2, 3};

0 commit comments

Comments
 (0)