Sql tests for various providers improved

working with transactions and connections and othere changes

Author: alex-kulakov

Orm/Xtensive.Orm.Tests.Sql/CompilerTest.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2015 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2015-2025 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexey Kulakov
 // Created:    2015.02.06
 
@@ -31,6 +31,18 @@ protected override void TestFixtureSetUp()
       DropSchema(initialCatalog);
       Catalog = ExtractCatalog();
       CreateTables(Catalog);
+      Connection.Close();
+      Connection.Open();
+    }
+
+    public override void SetUp()
+    {
+      Connection.BeginTransaction();
+    }
+
+    public override void TearDown()
+    {
+      Connection.Rollback();
     }
 
     [Test]

Orm/Xtensive.Orm.Tests.Sql/DateTimeIntervalTest.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2009-2025 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
 // Created:    2009.02.27
 
@@ -13,8 +13,15 @@ namespace Xtensive.Orm.Tests.Sql
 {
   public abstract class DateTimeIntervalTest : SqlTest
   {
-    protected static readonly DateTime DefaultDateTime = new DateTime(2001, 2, 3, 4, 5, 6, 334);
-    protected static readonly DateTime SecondDateTime = new DateTime(2000, 12, 11, 10, 9, 8, 765);
+    protected static readonly DateTime DefaultDateTime =
+      StorageProviderInfo.Instance.CheckProviderIs(StorageProvider.Firebird)
+        ? new DateTime(2001, 2, 3, 4, 5, 6)
+        : new DateTime(2001, 2, 3, 4, 5, 6, 334);
+    protected static readonly DateTime SecondDateTime =
+      StorageProviderInfo.Instance.CheckProviderIs(StorageProvider.Firebird)
+        ? new DateTime(2000, 12, 11, 10, 9, 8)
+        : new DateTime(2000, 12, 11, 10, 9, 8, 765);
+
     protected static readonly TimeSpan DefaultTimeSpan = new TimeSpan(10, 9, 8, 7, 652);
     protected static readonly int AddYearsConst = 5;
     protected static readonly int AddMonthsConst = 15;
@@ -23,24 +30,24 @@ public abstract class DateTimeIntervalTest : SqlTest
     public virtual void DateTimeAddIntervalTest()
     {
       CheckEquality(
-        SqlDml.DateTimePlusInterval(DefaultDateTime, DefaultTimeSpan),
+        SqlDml.DateTimePlusInterval(PrepareDateTimeLiteral(DefaultDateTime), DefaultTimeSpan),
         DefaultDateTime.Add(DefaultTimeSpan));
     }
 
     [Test]
     public virtual void DateTimeAddMonthsTest()
     {
       CheckEquality(
-        SqlDml.DateTimeAddMonths(DefaultDateTime, AddMonthsConst),
-        DefaultDateTime.AddMonths(AddMonthsConst));
+        SqlDml.DateTimeAddMonths(PrepareDateTimeLiteral(DefaultDateTime), AddMonthsConst),
+        PrepareDateTimeLiteral(DefaultDateTime.AddMonths(AddMonthsConst)));
     }
 
     [Test]
     public virtual void DateTimeAddYearsTest()
     {
       CheckEquality(
-        SqlDml.DateTimeAddYears(DefaultDateTime, AddYearsConst),
-        DefaultDateTime.AddYears(AddYearsConst));
+        SqlDml.DateTimeAddYears(PrepareDateTimeLiteral(DefaultDateTime), AddYearsConst),
+        PrepareDateTimeLiteral(DefaultDateTime.AddYears(AddYearsConst)));
     }
 
     [Test]
@@ -55,77 +62,78 @@ public virtual void DateTimeConstructTest()
     public virtual void DateTimeSubtractDateTimeTest()
     {
       CheckEquality(
-        SqlDml.DateTimeMinusDateTime(DefaultDateTime, SecondDateTime),
+        SqlDml.DateTimeMinusDateTime(PrepareDateTimeLiteral(DefaultDateTime), PrepareDateTimeLiteral(SecondDateTime)),
         DefaultDateTime.Subtract(SecondDateTime));
     }
 
     [Test]
     public virtual void DateTimeSubtractIntervalTest()
     {
       CheckEquality(
-        SqlDml.DateTimeMinusInterval(DefaultDateTime, DefaultTimeSpan),
+        SqlDml.DateTimeMinusInterval(PrepareDateTimeLiteral(DefaultDateTime), DefaultTimeSpan),
         DefaultDateTime.Subtract(DefaultTimeSpan));
     }
 
     [Test]
     public virtual void DateTimeTruncateTest()
     {
       CheckEquality(
-        SqlDml.DateTimeTruncate(DefaultDateTime),
-        DefaultDateTime.Date);
+        SqlDml.DateTimeTruncate(PrepareDateTimeLiteral(DefaultDateTime)),
+        PrepareDateTimeLiteral(DefaultDateTime.Date));
     }
 
     [Test]
     public virtual void DateTimeExtractYearTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.Year, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.Year, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.Year);
     }
 
     [Test]
     public virtual void DateTimeExtractMonthTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.Month, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.Month, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.Month);
     }
 
     [Test]
     public virtual void DateTimeExtractDayTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.Day, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.Day, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.Day);
     }
 
     [Test]
     public virtual void DateTimeExtractHourTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.Hour, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.Hour, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.Hour);
     }
 
     [Test]
     public virtual void DateTimeExtractMinuteTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.Minute, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.Minute, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.Minute);
     }
 
     [Test]
     public virtual void DateTimeExtractSecondTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.Second, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.Second, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.Second);
     }
 
     [Test]
     public virtual void DateTimeExtractMillisecondTest()
     {
+      Require.ProviderIsNot(StorageProvider.Firebird);
       CheckEquality(
         SqlDml.Extract(SqlDateTimePart.Millisecond, DefaultDateTime),
         DefaultDateTime.Millisecond);
@@ -135,15 +143,15 @@ public virtual void DateTimeExtractMillisecondTest()
     public virtual void DateTimeExtractDayOfWeekTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.DayOfWeek, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.DayOfWeek, PrepareDateTimeLiteral(DefaultDateTime)),
         (int) DefaultDateTime.DayOfWeek);
     }
 
     [Test]
     public virtual void DateTimeExtractDayOfYearTest()
     {
       CheckEquality(
-        SqlDml.Extract(SqlDateTimePart.DayOfYear, DefaultDateTime),
+        SqlDml.Extract(SqlDateTimePart.DayOfYear, PrepareDateTimeLiteral(DefaultDateTime)),
         DefaultDateTime.DayOfYear);
     }
 
@@ -222,5 +230,13 @@ protected void CheckEquality(SqlExpression left, SqlExpression right)
         }
       }
     }
+
+    private SqlExpression PrepareDateTimeLiteral(DateTime value)
+    {
+      if (StorageProviderInfo.Instance.CheckProviderIs(StorageProvider.Firebird)) {
+        return SqlDml.Cast(SqlDml.Literal(value), SqlType.DateTime);
+      }
+      return SqlDml.Literal(value);
+    }
   }
 }

Orm/Xtensive.Orm.Tests.Sql/DriverFactoryTest.cs

@@ -1,11 +1,9 @@
-// Copyright (C) 2009-2021 Xtensive LLC.
+// Copyright (C) 2009-2025 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 
 using System;
 using NUnit.Framework;
-using Xtensive.Core;
-using Xtensive.Orm;
 using Xtensive.Orm.Building.Builders;
 using Xtensive.Sql;
 using Xtensive.Orm.Tests.Sql.DriverFactoryTestTypes;
@@ -53,8 +51,8 @@ namespace Xtensive.Orm.Tests.Sql
   public class DriverFactoryTest
   {
     private string provider = TestConnectionInfoProvider.GetProvider();
-    protected string Url = TestConnectionInfoProvider.GetConnectionUrl();
-    protected string ConnectionString = TestConnectionInfoProvider.GetConnectionString();
+    private string url = TestConnectionInfoProvider.GetConnectionUrl();
+    private string connectionString = TestConnectionInfoProvider.GetConnectionString();
 
     [Test]
     public void ConnectionUrlTest()
@@ -86,14 +84,14 @@ public void ServerInfoTest()
     {
       Require.ProviderIs(StorageProvider.SqlServer);
       Require.ProviderVersionAtLeast(StorageProviderVersion.SqlServer2005);
-      var driver = TestSqlDriver.Create(Url);
+      var driver = TestSqlDriver.Create(url);
       Assert.Greater(driver.CoreServerInfo.ServerVersion.Major, 8);
     }
 
     [Test]
     public void ProviderTest()
     {
-      TestProvider(provider, ConnectionString, Url);
+      TestProvider(provider, connectionString, url);
     }
 
     [Test]
@@ -104,32 +102,32 @@ public void SqlServerConnectionCheckTest()
       var factory = (SqlDriverFactory) Activator.CreateInstance(descriptor.DriverFactory);
 
       var configuration = new SqlDriverConfiguration() { EnsureConnectionIsAlive = false };
-      var driver = factory.GetDriver(new ConnectionInfo(Url), configuration);
+      var driver = factory.GetDriver(new ConnectionInfo(url), configuration);
       Assert.That(GetCheckConnectionIsAliveFlag(driver), Is.False);
 
       configuration = configuration.Clone();
       configuration.EnsureConnectionIsAlive = true;
-      driver = factory.GetDriver(new ConnectionInfo(Url), configuration);
+      driver = factory.GetDriver(new ConnectionInfo(url), configuration);
       Assert.That(GetCheckConnectionIsAliveFlag(driver), Is.True);
 
       configuration = configuration.Clone();
       configuration.EnsureConnectionIsAlive = true;
-      driver = factory.GetDriver(new ConnectionInfo(provider, ConnectionString + ";pooling=false"), configuration);
+      driver = factory.GetDriver(new ConnectionInfo(provider, connectionString + ";pooling=false"), configuration);
       Assert.That(GetCheckConnectionIsAliveFlag(driver), Is.False);
 
       configuration = configuration.Clone();
       configuration.EnsureConnectionIsAlive = true;
-      driver = factory.GetDriver(new ConnectionInfo(provider, ConnectionString + ";Pooling=False"), configuration);
+      driver = factory.GetDriver(new ConnectionInfo(provider, connectionString + ";Pooling=False"), configuration);
       Assert.That(GetCheckConnectionIsAliveFlag(driver), Is.False);
 
       configuration = configuration.Clone();
       configuration.EnsureConnectionIsAlive = true;
-      driver = factory.GetDriver(new ConnectionInfo(provider, ConnectionString + ";pooling = false"), configuration);
+      driver = factory.GetDriver(new ConnectionInfo(provider, connectionString + ";pooling = false"), configuration);
       Assert.That(GetCheckConnectionIsAliveFlag(driver), Is.False);
 
       configuration = configuration.Clone();
       configuration.EnsureConnectionIsAlive = true;
-      driver = factory.GetDriver(new ConnectionInfo(provider, ConnectionString + ";Pooling = False"), configuration);
+      driver = factory.GetDriver(new ConnectionInfo(provider, connectionString + ";Pooling = False"), configuration);
       Assert.That(GetCheckConnectionIsAliveFlag(driver), Is.False);
     }
 
@@ -147,14 +145,14 @@ public void ConnectionAccessorTest()
       Assert.That(accessorInstance.OpeningFailedCounter, Is.EqualTo(0));
 
       var configuration = new SqlDriverConfiguration(accessorsArray);
-      _ = factory.GetDriver(new ConnectionInfo(Url), configuration);
+      _ = factory.GetDriver(new ConnectionInfo(url), configuration);
       Assert.That(accessorInstance.OpeningCounter, Is.EqualTo(1));
       Assert.That(accessorInstance.OpeningInitCounter, Is.EqualTo(0));
       Assert.That(accessorInstance.OpenedCounter, Is.EqualTo(1));
       Assert.That(accessorInstance.OpeningFailedCounter, Is.EqualTo(0));
 
       configuration = new SqlDriverConfiguration(accessorsArray) { EnsureConnectionIsAlive = true };
-      _ = factory.GetDriver(new ConnectionInfo(Url), configuration);
+      _ = factory.GetDriver(new ConnectionInfo(url), configuration);
       Assert.That(accessorInstance.OpeningCounter, Is.EqualTo(2));
       if (provider == WellKnown.Provider.SqlServer)
         Assert.That(accessorInstance.OpeningInitCounter, Is.EqualTo(1));
@@ -164,7 +162,7 @@ public void ConnectionAccessorTest()
       Assert.That(accessorInstance.OpeningFailedCounter, Is.EqualTo(0));
 
       configuration = new SqlDriverConfiguration(accessorsArray) { ConnectionInitializationSql = InitQueryPerProvider(provider) };
-      _ = factory.GetDriver(new ConnectionInfo(Url), configuration);
+      _ = factory.GetDriver(new ConnectionInfo(url), configuration);
       Assert.That(accessorInstance.OpeningCounter, Is.EqualTo(3));
       if (provider == WellKnown.Provider.SqlServer)
         Assert.That(accessorInstance.OpeningInitCounter, Is.EqualTo(2));
@@ -175,7 +173,7 @@ public void ConnectionAccessorTest()
 
       configuration = new SqlDriverConfiguration(accessorsArray) { ConnectionInitializationSql = "dummy string to trigger error" };
       try {
-        _ = factory.GetDriver(new ConnectionInfo(Url), configuration);
+        _ = factory.GetDriver(new ConnectionInfo(url), configuration);
       }
       catch {
         //skip it

Orm/Xtensive.Orm.Tests.Sql/ExceptionTypesTest.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2010-2025 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
 // Created:    2010.02.08
 
@@ -37,12 +37,14 @@ protected override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
       schema = ExtractDefaultSchema();
+      Connection.BeginTransaction();
       EnsureTableNotExists(schema, TimeoutTableName);
       EnsureTableNotExists(schema, DeadlockTableName);
       EnsureTableNotExists(schema, SlaveTableName);
       EnsureTableNotExists(schema, MasterTableName);
       EnsureTableNotExists(schema, UniqueTableName);
       EnsureTableNotExists(schema, CheckedTableName);
+      Connection.Commit();
     }
 
     public override void TearDown()
@@ -222,9 +224,13 @@ public virtual void DeadlockTest()
     [Test]
     public virtual void TimeoutTest()
     {
+      Require.ProviderIsNot(StorageProvider.Firebird, "For Some reason one of transactions \"sees\" uncommited insert and no timeout happens");
+
+      Connection.BeginTransaction();
       var table = schema.CreateTable(TimeoutTableName);
       CreatePrimaryKey(table);
       ExecuteNonQuery(SqlDdl.Create(table));
+      Connection.Commit();
 
       var tableRef = SqlDml.TableRef(table);
       var insert = SqlDml.Insert(tableRef);