Fix & improve error messages

Author: JojiiOfficial

handlers/Errors.go

@@ -54,33 +54,33 @@ func NewRequestError(msg string, code int) *RequestError {
 }
 
 // Prepend text to the error
-func (re *RequestError) Prepend(txt string) *RequestError {
+func (re RequestError) Prepend(txt string) *RequestError {
 	// Check if space has to be added
 	if strings.HasSuffix(txt, " ") || strings.HasPrefix(re.Message, " ") {
 		re.Message = txt + re.Message
 	} else {
-		re.Message = txt + "  " + re.Message
+		re.Message = txt + " " + re.Message
 	}
 
-	return re
+	return &re
 }
 
 // Append text to the error
-func (re *RequestError) Append(txt string) *RequestError {
+func (re RequestError) Append(txt string) *RequestError {
 	// Check if space has to be added
 	if strings.HasSuffix(re.Message, " ") || strings.HasPrefix(txt, " ") {
 		re.Message += txt
 	} else {
 		re.Message += " " + txt
 	}
 
-	return re
+	return &re
 }
 
 // WithCode uses a different HTTP responsecode
-func (re *RequestError) WithCode(code int) *RequestError {
+func (re RequestError) WithCode(code int) *RequestError {
 	re.ResponseCode = code
-	return re
+	return &re
 }
 
 // Implement String for error

handlers/FileAttrHandler.go

@@ -62,7 +62,7 @@ func AttributeHandler(handlerData web.HandlerData, w http.ResponseWriter, r *htt
 
 				// Find instance
 				tag, err := models.FindTag(handlerData.Db, request.Name, namespace, handlerData.User)
-				if tag == nil || LogError(err) {
+				if tag == nil && err != nil {
 					return RErrNotFound.Prepend("Tag")
 				}
 
@@ -73,9 +73,8 @@ func AttributeHandler(handlerData web.HandlerData, w http.ResponseWriter, r *htt
 						tag.Name = request.NewName
 						err := handlerData.Db.Save(tag).Error
 
-						if LogError(err) {
-							sendServerError(w)
-							return nil
+						if err != nil {
+							return err
 						}
 					}
 				case "delete":
@@ -96,7 +95,6 @@ func AttributeHandler(handlerData web.HandlerData, w http.ResponseWriter, r *htt
 			}
 		case "get":
 			{
-
 				var tags []models.Tag
 				err := handlerData.Db.Model(&models.Tag{}).Where("namespace_id=?", namespace.ID).Find(&tags).Error
 				if err != nil {
@@ -175,7 +173,6 @@ func AttributeHandler(handlerData web.HandlerData, w http.ResponseWriter, r *htt
 			}
 		case "get":
 			{
-
 				var groups []models.Group
 				err := handlerData.Db.Model(&models.Group{}).Where("namespace_id=?", namespace.ID).Find(&groups).Error
 				if err != nil {

handlers/Router.go

@@ -215,7 +215,7 @@ func RouteHandler(requestType requestType, handlerData *web.HandlerData, inner R
 
 		// Process request and handle its error
 		if err := inner(*handlerData, w, r); err != nil {
-			if e, ok := err.(RequestError); ok {
+			if e, ok := err.(*RequestError); ok {
 				// Send error response to user
 				sendResponse(w, models.ResponseError, e.String(), "", e.ResponseCode)