Skip to content

Commit 4bda592

Browse files
committed
py_lua_helper: refactor some internal class fields
1 parent 2fd1f34 commit 4bda592

1 file changed

Lines changed: 20 additions & 20 deletions

File tree

python_lua_helper/py_lua_helper.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ def __init__(
5050
self._pre_script = pre_script
5151
self._post_script = post_script
5252
self._extra_strings = extra_strings or []
53-
self.work_dir = work_dir or os.path.dirname(self._lua_config_script)
54-
self.temp_dir = temp_dir
53+
self._work_dir = work_dir or os.path.dirname(self._lua_config_script)
54+
self._temp_dir = temp_dir
5555
self.min_lua_version = min_lua_version or "5.1.0"
5656
self.max_lua_version = max_lua_version or "5.4.999"
5757
self.lua_binary = lua_binary
@@ -81,11 +81,11 @@ def __init__(
8181

8282
def _setup_temp_dir(self):
8383
"""Setup temporary directory for storing exported variables."""
84-
if self.temp_dir:
85-
if not os.path.exists(self.temp_dir):
86-
raise ValueError(f"Temp directory does not exist: {self.temp_dir}")
87-
self.temp_dir = os.path.abspath(self.temp_dir)
88-
self.temp_dir = tempfile.mkdtemp(prefix="lua-helper-", dir=self.temp_dir)
84+
if self._temp_dir:
85+
if not os.path.exists(self._temp_dir):
86+
raise ValueError(f"Temp directory does not exist: {self._temp_dir}")
87+
self._temp_dir = os.path.abspath(self._temp_dir)
88+
self._temp_dir = tempfile.mkdtemp(prefix="lua-helper-", dir=self._temp_dir)
8989
else:
9090
# Detect temp directory if not provided, platform dependent
9191
if os.name == "nt": # Windows
@@ -103,7 +103,7 @@ def _setup_temp_dir(self):
103103
for base_dir in temp_dirs:
104104
try:
105105
# Try to create temp directory in this location
106-
self.temp_dir = tempfile.mkdtemp(
106+
self._temp_dir = tempfile.mkdtemp(
107107
prefix="lua-helper-", dir=base_dir
108108
)
109109
break
@@ -135,20 +135,20 @@ def _setup_temp_dir(self):
135135
text=True,
136136
)
137137
if result.returncode == 0:
138-
self.temp_dir = target
138+
self._temp_dir = target
139139
break
140140
except Exception:
141141
continue
142-
if not self.temp_dir:
143-
self.temp_dir = "/tmp"
142+
if not self._temp_dir:
143+
self._temp_dir = "/tmp"
144144
# Create unique temp directory
145-
self.temp_dir = tempfile.mkdtemp(
146-
prefix="lua-helper-", dir=self.temp_dir
145+
self._temp_dir = tempfile.mkdtemp(
146+
prefix="lua-helper-", dir=self._temp_dir
147147
)
148148
# Define temp files for data exchange
149-
self._meta_file = os.path.join(self.temp_dir, "meta.tmp")
150-
self._data_file = os.path.join(self.temp_dir, "data.tmp")
151-
self._index_file = os.path.join(self.temp_dir, "index.tmp")
149+
self._meta_file = os.path.join(self._temp_dir, "meta.tmp")
150+
self._data_file = os.path.join(self._temp_dir, "data.tmp")
151+
self._index_file = os.path.join(self._temp_dir, "index.tmp")
152152

153153
def _detect_lua_binary(self):
154154
"""Detect appropriate Lua binary based on version requirements."""
@@ -243,9 +243,9 @@ def _run_lua_loader(self):
243243
for extra in self._extra_strings:
244244
cmd.extend(["-ext", extra])
245245
# Add work directory
246-
cmd.extend(["-w", self.work_dir])
246+
cmd.extend(["-w", self._work_dir])
247247
# Add temp directory
248-
cmd.extend(["-t", self.temp_dir])
248+
cmd.extend(["-t", self._temp_dir])
249249
# Add -- separator
250250
cmd.append("--")
251251
# Add additional Lua arguments
@@ -314,9 +314,9 @@ def _parse_results(self):
314314

315315
def _cleanup(self):
316316
"""Clean up temporary directory."""
317-
if self.temp_dir and os.path.exists(self.temp_dir):
317+
if self._temp_dir and os.path.exists(self._temp_dir):
318318
try:
319-
shutil.rmtree(self.temp_dir)
319+
shutil.rmtree(self._temp_dir)
320320
except Exception:
321321
pass
322322

0 commit comments

Comments
 (0)