Skip to content

Commit 34228aa

Browse files
committed
Add featuresConfig to GraphicsCoreStore, clean-up & fixes
1 parent f00e6b4 commit 34228aa

5 files changed

Lines changed: 14 additions & 9 deletions

File tree

src/engine/renderer-vulkan/GraphicsCore/Decls.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ struct VkAllocationCallbacks;
5555

5656
struct Semaphore;
5757

58+
struct VkPhysicalDeviceProperties2;
59+
struct VkPhysicalDeviceFeatures2;
5860
struct VkDeviceCreateInfo;
5961

6062
VK_DEFINE_HANDLE( VkInstance );

src/engine/renderer-vulkan/GraphicsCore/GraphicsCoreStore.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
4141

4242
#include "SwapChain.h"
4343

44+
#include "FeaturesConfig.h"
4445
#include "EngineConfig.h"
4546
#include "QueuesConfig.h"
4647
#include "Queue.h"
@@ -55,8 +56,9 @@ Instance instance;
5556

5657
SwapChain mainSwapChain;
5758

58-
EngineConfig engineConfig;
59-
QueuesConfig queuesConfig;
59+
FeaturesConfig featuresConfig;
60+
EngineConfig engineConfig;
61+
QueuesConfig queuesConfig;
6062

6163
VkPhysicalDevice physicalDevice;
6264

src/engine/renderer-vulkan/GraphicsCore/GraphicsCoreStore.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,9 @@ extern Instance instance;
4444

4545
extern SwapChain mainSwapChain;
4646

47-
extern EngineConfig engineConfig;
48-
extern QueuesConfig queuesConfig;
47+
extern FeaturesConfig featuresConfig;
48+
extern EngineConfig engineConfig;
49+
extern QueuesConfig queuesConfig;
4950

5051
extern VkPhysicalDevice physicalDevice;
5152

src/engine/renderer-vulkan/GraphicsCore/Init.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ void InitGraphicsEngine() {
7373
return;
7474
}
7575

76-
uint32 presentSupported;
7776
if ( queuesConfig.computeQueue.unique ) {
7877
computeQueue.Init( device, queuesConfig.computeQueue.id, queuesConfig.computeQueue.queueCount );
7978
vkGetPhysicalDeviceSurfaceSupportKHR( physicalDevice, queuesConfig.computeQueue.id, mainSwapChain.surface, &presentSupported );

src/engine/renderer-vulkan/GraphicsCore/PhysicalDevice.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
4646
#include "QueuesConfig.h"
4747
#include "CapabilityPack.h"
4848

49+
#include "GraphicsCoreStore.h"
50+
4951
#include "PhysicalDevice.h"
5052

5153
#include "FeaturesConfig.h"
@@ -154,9 +156,8 @@ void CreateDevice( const VkPhysicalDevice& physicalDevice, EngineConfig& config,
154156
queueInfo.pQueuePriorities = priorities.memory;
155157
}
156158

157-
FeaturesConfig cfgF = GetPhysicalDeviceFeatures( physicalDevice, config );
158-
FeaturesConfig cfgOut;
159-
DynamicArray<const char*> ext = GetCapabilityPackFeatures( ( CapabilityPackType::Type ) config.capabilityPack, cfgF, &cfgOut );
159+
FeaturesConfig cfg = GetPhysicalDeviceFeatures( physicalDevice, config );
160+
DynamicArray<const char*> ext = GetCapabilityPackFeatures( ( CapabilityPackType::Type ) config.capabilityPack, cfg, &featuresConfig );
160161

161162
VkDeviceCreateInfo info {
162163
.queueCreateInfoCount = queuesConfig.count,
@@ -165,7 +166,7 @@ void CreateDevice( const VkPhysicalDevice& physicalDevice, EngineConfig& config,
165166
.ppEnabledExtensionNames = ext.memory
166167
};
167168

168-
VkResult res = ( VkResult ) CreatePhysicalDevice( info, nullptr, config, cfgOut, device );
169+
VkResult res = ( VkResult ) CreatePhysicalDevice( info, nullptr, config, featuresConfig, device );
169170
Q_UNUSED( res );
170171
Q_UNUSED( config );
171172
}

0 commit comments

Comments
 (0)