Skip to content

Commit 72106ec

Browse files
committed
fix: og meta tags were not rendered on the server
1 parent b3ab898 commit 72106ec

2 files changed

Lines changed: 36 additions & 36 deletions

File tree

nextjs/PageNextJs.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React from 'react';
22

33
import type { Route } from 'nextjs-routes';
44
import type { Props as PageProps } from 'nextjs/getServerSideProps/handlers';
5-
import PageMetadata from 'nextjs/PageMetadata';
65

76
import useAdblockDetect from 'lib/hooks/useAdblockDetect';
87
import useGetCsrfToken from 'lib/hooks/useGetCsrfToken';
@@ -27,12 +26,7 @@ const PageNextJs = <Pathname extends Route['pathname']>(props: Props<Pathname>)
2726
const isMixPanelInitialized = mixpanel.useInit();
2827
mixpanel.useLogPageView(isMixPanelInitialized);
2928

30-
return (
31-
<>
32-
<PageMetadata pathname={ props.pathname } query={ props.query } apiData={ props.apiData }/>
33-
{ isMounted ? props.children : null }
34-
</>
35-
);
29+
return isMounted ? props.children : null;
3630
};
3731

3832
export default React.memo(PageNextJs);

pages/_app.tsx

Lines changed: 35 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ import React from 'react';
88

99
import type { NextPageWithLayout } from 'nextjs/types';
1010

11+
import type { Route } from 'nextjs-routes';
12+
import PageMetadata from 'nextjs/PageMetadata';
13+
1114
import config from 'configs/app';
1215
import getSocketUrl from 'lib/api/getSocketUrl';
1316
import useQueryClientConfig from 'lib/api/useQueryClientConfig';
@@ -57,7 +60,7 @@ If you don't understand what this console is for, close it now and stay safe.`;
5760

5861
const CONSOLE_SCAM_WARNING_DELAY_MS = 500;
5962

60-
function MyApp({ Component, pageProps }: AppPropsWithLayout) {
63+
function MyApp({ Component, pageProps, router }: AppPropsWithLayout) {
6164

6265
const growthBook = initGrowthBook(pageProps.uuid);
6366
useLoadFeatures(growthBook);
@@ -96,34 +99,37 @@ function MyApp({ Component, pageProps }: AppPropsWithLayout) {
9699
const socketUrl = !config.features.multichain.isEnabled ? getSocketUrl() : undefined;
97100

98101
return (
99-
<ChakraProvider>
100-
<RollbarProvider config={ rollbarConfig }>
101-
<AppErrorBoundary
102-
{ ...ERROR_SCREEN_STYLES }
103-
Container={ AppErrorGlobalContainer }
104-
>
105-
<QueryClientProvider client={ queryClient }>
106-
<Web3Provider>
107-
<AppContextProvider pageProps={ pageProps }>
108-
<GrowthBookProvider growthbook={ growthBook }>
109-
<SocketProvider url={ socketUrl }>
110-
<RewardsProvider>
111-
<MarketplaceContextProvider>
112-
<SettingsContextProvider>
113-
{ content }
114-
</SettingsContextProvider>
115-
</MarketplaceContextProvider>
116-
</RewardsProvider>
117-
</SocketProvider>
118-
</GrowthBookProvider>
119-
<ReactQueryDevtools buttonPosition="bottom-left" position="left"/>
120-
<GoogleAnalytics/>
121-
</AppContextProvider>
122-
</Web3Provider>
123-
</QueryClientProvider>
124-
</AppErrorBoundary>
125-
</RollbarProvider>
126-
</ChakraProvider>
102+
<>
103+
<PageMetadata pathname={ router.pathname as Route['pathname'] } query={ pageProps.query } apiData={ pageProps.apiData }/>
104+
<ChakraProvider>
105+
<RollbarProvider config={ rollbarConfig }>
106+
<AppErrorBoundary
107+
{ ...ERROR_SCREEN_STYLES }
108+
Container={ AppErrorGlobalContainer }
109+
>
110+
<QueryClientProvider client={ queryClient }>
111+
<Web3Provider>
112+
<AppContextProvider pageProps={ pageProps }>
113+
<GrowthBookProvider growthbook={ growthBook }>
114+
<SocketProvider url={ socketUrl }>
115+
<RewardsProvider>
116+
<MarketplaceContextProvider>
117+
<SettingsContextProvider>
118+
{ content }
119+
</SettingsContextProvider>
120+
</MarketplaceContextProvider>
121+
</RewardsProvider>
122+
</SocketProvider>
123+
</GrowthBookProvider>
124+
<ReactQueryDevtools buttonPosition="bottom-left" position="left"/>
125+
<GoogleAnalytics/>
126+
</AppContextProvider>
127+
</Web3Provider>
128+
</QueryClientProvider>
129+
</AppErrorBoundary>
130+
</RollbarProvider>
131+
</ChakraProvider>
132+
</>
127133
);
128134
}
129135

0 commit comments

Comments
 (0)