Skip to content

Commit 171aefc

Browse files
committed
add some more rigorous column ordering tests
1 parent 2131316 commit 171aefc

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

tests/waterdata_test.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,20 @@ def test_get_daily_properties():
140140
time="2025-01-01/..",
141141
properties=["daily_id", "monitoring_location_id", "parameter_code", "time", "value", "geometry"]
142142
)
143-
assert "daily_id" in df.columns
144-
assert "geometry" in df.columns
143+
assert "daily_id" == df.columns[0]
144+
assert "geometry" == df.columns[-1]
145145
assert df.shape[1] == 6
146146
assert df.parameter_code.unique().tolist() == ["00060"]
147147

148+
def test_get_daily_properties_id():
149+
df,_ = get_daily(
150+
monitoring_location_id="USGS-05427718",
151+
parameter_code="00060",
152+
time="2025-01-01/..",
153+
properties=["monitoring_location_id", "id", "parameter_code", "time", "value", "geometry"]
154+
)
155+
assert "daily_id" == df.columns[1]
156+
148157
def test_get_daily_no_geometry():
149158
df,_ = get_daily(
150159
monitoring_location_id="USGS-05427718",
@@ -188,7 +197,7 @@ def test_get_latest_continuous():
188197
monitoring_location_id=["USGS-05427718", "USGS-05427719"],
189198
parameter_code=["00060", "00065"]
190199
)
191-
assert "latest_continuous_id" in df.columns
200+
assert "latest_continuous_id" == df.columns[-1]
192201
assert df.shape[0] <= 4
193202
assert df.statistic_id.unique().tolist() == ["00011"]
194203
assert hasattr(md, 'url')

0 commit comments

Comments
 (0)