Skip to content

Commit d1274eb

Browse files
committed
SysUI: Don't set panel bar to null and avoid NPEs
This patch removes the onDetachedFromWindow method introduced in change Ieaec759e4378a9a7701e6fba46ed33464caaee0a. It is not necessary to set the panel bar to null in the PanelViews or the PanelHolder in order for these objects to be GC'ed when recreating the status bar after a theme change or a user switch. Change-Id: I67f1e8289d04df2f5daefdb206030d7f0404d714 TICKET: HAM-1551
1 parent e2b1a0a commit d1274eb

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

  • packages/SystemUI/src/com/android/systemui/statusbar/phone

packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,6 @@ public boolean onTouchEvent(MotionEvent event) {
146146
return result;
147147
}
148148

149-
@Override
150-
protected void onDetachedFromWindow() {
151-
super.onDetachedFromWindow();
152-
for (PanelView pv : mPanels) {
153-
pv.setBar(null);
154-
}
155-
mPanels.clear();
156-
mPanelHolder.setBar(null);
157-
}
158-
159149
// called from PanelView when self-expanding, too
160150
public void startOpeningPanel(PanelView panel) {
161151
if (DEBUG) LOG("startOpeningPanel: " + panel);

0 commit comments

Comments
 (0)