Merge pull request #14 from dxw/update-entries-validation-errors-api-to-match-lambda

Update entries API to accept multiple errors

Author: tekin

app/controllers/v1/submission_entries_controller.rb

@@ -52,6 +52,8 @@ def initialize_submission_entry
   end
 
   def submission_entry_params
-    params.require(:submission_entry).permit(:status, source: {}, data: {}, validation_errors: {})
+    params
+      .require(:submission_entry)
+      .permit(:status, :type, source: {}, data: {}, validation_errors: [:message, location: {}])
   end
 end

spec/requests/v1/files_spec.rb

@@ -131,13 +131,12 @@
         data: {
           type: 'submission_entries',
           attributes: {
-            validation_errors: {
-              location: {
-                row: 20,
-                column: 2
-              },
-              message: 'Required value error'
-            }
+            validation_errors: [
+              {
+                location: { row: 20, column: 2 },
+                message: 'Required value error'
+              }
+            ]
           }
         }
       }
@@ -153,7 +152,8 @@
 
       expect(response).to have_http_status(:no_content)
       expect(entry.reload).to be_pending
-      expect(entry.reload.validation_errors['message']).to eql 'Required value error'
+      expect(entry.validation_errors[0]['message']).to eq 'Required value error'
+      expect(entry.validation_errors[0]['location']).to eq('row' => 20, 'column' => 2)
     end
 
     it 'updates both the given entry\'s status and the validation errors received from DAVE' do
@@ -167,13 +167,12 @@
           type: 'submission_entries',
           attributes: {
             status: 'errored',
-            validation_errors: {
-              location: {
-                row: 20,
-                column: 2
-              },
-              message: 'Required value error'
-            }
+            validation_errors: [
+              {
+                location: { row: 20, column: 2 },
+                message: 'Required value error'
+              }
+            ]
           }
         }
       }
@@ -189,7 +188,8 @@
 
       expect(response).to have_http_status(:no_content)
       expect(entry.reload).to be_errored
-      expect(entry.reload.validation_errors['message']).to eql 'Required value error'
+      expect(entry.validation_errors[0]['message']).to eq 'Required value error'
+      expect(entry.validation_errors[0]['location']).to eq('row' => 20, 'column' => 2)
     end
   end