Transition errored submissions to "in_review"

If all the rows have been processed but some have errors, we want to
transition the submission to an "in_review" state so that the user will
see the errors and is able to correct them on the frontend.

Note that we're allowing transition from "pending", as well as
"processed". In theory, we should only ever transition a "processing"
submission to "in_review", but at the moment there is no part of the
system that transitions a submission out of "pending"; instead the
ingest and validation is triggered whilst they are still "pending". The
plan is to update the ingest script so that it transitions the
submission to "processing" when it starts, but until that is done we
wan to be able to see the submissions flowing through the various
states.

Author: tekin

app/models/submission.rb

@@ -14,5 +14,9 @@ class Submission < ApplicationRecord
     state :in_review
     state :completed
     state :rejected
+
+    event :ready_for_review do
+      transitions from: %i[pending processing], to: :in_review
+    end
   end
 end

app/models/submission_status_update.rb

@@ -9,6 +9,7 @@ def perform!
     return unless submission.entries.any?
 
     trigger_levy_calculation if all_entries_valid?
+    transition_to_in_review if no_entries_pending? && some_entries_errored?
   end
 
   private
@@ -17,6 +18,18 @@ def all_entries_valid?
     submission.entries.validated.count == submission.entries.count
   end
 
+  def transition_to_in_review
+    submission.ready_for_review!
+  end
+
+  def no_entries_pending?
+    submission.entries.pending.none?
+  end
+
+  def some_entries_errored?
+    submission.entries.errored.any?
+  end
+
   def trigger_levy_calculation
     AWSLambdaService.new(submission_id: submission.id).trigger
   end

spec/models/submission_status_update_spec.rb

@@ -65,6 +65,12 @@
       context 'with no "pending" entries remaining, but some having failed validation' do
         let(:submission) { FactoryBot.create(:submission_with_invalid_entries, aasm_state: :processing) }
 
+        it 'transitions the submission to "in_review"' do
+          submission_status_check.perform!
+
+          expect(submission).to be_in_review
+        end
+
         it 'does not trigger a levy calculation' do
           expect(aws_lambda_service_double).not_to receive(:trigger)