(feature) Unfinished submissions cannot be completed

Only valid submissions that are 'in review' may be completed. Once this
happens, we also mark the associated task as complete too.

If either of these status changes fail, we return a 'bad request' HTTP
status, else we return HTTP 204 No Content.

Author: leeky

app/controllers/v1/submissions_controller.rb

@@ -49,7 +49,7 @@ def complete
     submission = Submission.find(params[:id])
     complete_submission!(submission)
 
-    if submission.save
+    if submission.errors.empty?
       head :no_content
     else
       render jsonapi_errors: submission.errors, status: :bad_request

app/models/submission.rb

@@ -20,7 +20,15 @@ class Submission < ApplicationRecord
     end
 
     event :reviewed_and_accepted do
-      transitions from: :in_review, to: :completed
+      transitions from: :in_review, to: :completed, guard: :all_entries_valid?
+
+      error do |e|
+        errors.add(:aasm_state, message: e.message)
+      end
     end
   end
+
+  def all_entries_valid?
+    entries.validated.count == entries.count
+  end
 end

app/models/submission_completion.rb

@@ -6,19 +6,10 @@ def initialize(submission)
   end
 
   def perform!
-    return unless all_entries_valid?
-
-    Task.transaction do
-      Submission.transaction do
-        submission.reviewed_and_accepted!
-        submission.task.completed!
-      end
+    submission.reviewed_and_accepted! do
+      submission.task.completed!
     end
-  end
-
-  private
 
-  def all_entries_valid?
-    submission.entries.validated.count == submission.entries.count
+    submission
   end
 end

spec/requests/v1/submissions_spec.rb

@@ -243,23 +243,47 @@
   end
 
   describe 'POST /submissions/:submission_id/complete' do
-    it 'marks the submission as complete' do
-      task = FactoryBot.create(:task, status: :in_progress)
+    context 'given a valid submission' do
+      it 'marks the submission as complete' do
+        task = FactoryBot.create(:task, status: :in_progress)
 
-      submission = FactoryBot.create(
-        :submission_with_validated_entries,
-        aasm_state: :in_review,
-        task: task
-      )
+        submission = FactoryBot.create(
+          :submission_with_validated_entries,
+          aasm_state: :in_review,
+          task: task
+        )
 
-      post "/v1/submissions/#{submission.id}/complete"
+        post "/v1/submissions/#{submission.id}/complete"
 
-      expect(response).to be_successful
+        expect(response).to be_successful
 
-      submission.reload
+        submission.reload
+
+        expect(submission).to be_completed
+        expect(submission.task).to be_completed
+      end
+    end
+
+    context 'given an invalid submission' do
+      it 'returns an error' do
+        task = FactoryBot.create(:task, status: :in_progress)
+
+        submission = FactoryBot.create(
+          :submission_with_invalid_entries,
+          aasm_state: :in_review,
+          task: task
+        )
+
+        post "/v1/submissions/#{submission.id}/complete"
+
+        expect(response).to have_http_status(:bad_request)
+        expect(json['errors'][0]['title']).to eql 'Invalid aasm_state'
+
+        submission.reload
 
-      expect(submission).to be_completed
-      expect(submission.task).to be_completed
+        expect(submission).to be_in_review
+        expect(task).to be_in_progress
+      end
     end
   end
 end