Fixed tests on cloud functions on createUser and on function import

Author: tpiaggio

functions/test/createUser.test.ts

@@ -1,39 +1,45 @@
-import { test } from './util/admin';
+import { admin, test } from './util/admin';
 import { https } from 'firebase-functions';
 import * as chai from 'chai';
+import * as createUser from '../src/https/createUser.function';
 import 'mocha';
 
-describe('onCreateUser', () => {
-  let onCreateUser: any;
+describe('createUser', () => {
+  let userRecord: any;
 
-  before(async () => {
-    onCreateUser = require('../src/https/createUser.function');
+  after(async () => {
+    await admin.auth().deleteUser(userRecord.uid);
   });
 
   it('should throw an error because the email is not provided', () => {
-    const wrapped = test.wrap(onCreateUser);
+    const wrapped = test.wrap(createUser.default);
 
     const data = {
       email: '',
       isAdmin: false
     };
 
-    return wrapped(data).then(() => {
-      chai.expect(https.HttpsError, 'auth/invalid-email');
-    });
+    return chai
+        .expect(wrapped(data))
+        .to.be.rejectedWith(
+          https.HttpsError,
+          'auth/invalid-email'
+        );
   });
 
-  it('should create the user into the database', () => {
-    const wrapped = test.wrap(onCreateUser);
+  it('should create the user in auth with correct email and custom claims', () => {
+    const wrapped = test.wrap(createUser.default);
 
     const data = {
-      uid: '1234',
       email: 'user@example.com',
       isAdmin: false
     };
 
-    return wrapped(data).then((res: any) => {
-      chai.assert.equal(data.uid, res.uid);
+    return wrapped(data).then(async (res: any) => {
+      userRecord = await admin.auth().getUser(res.uid);
+
+      chai.assert.equal(data.email, userRecord.email);
+      chai.assert.equal(data.isAdmin, userRecord.customClaims!.isAdmin);
     });
   });
 });

functions/test/onDelete.test.ts

@@ -1,12 +1,12 @@
 import { admin, test } from './util/admin';
 import * as chai from 'chai';
 import * as chaiAsPromised from 'chai-as-promised';
+import * as onDelete from '../src/db/users/onDelete.function';
 import 'mocha';
 
 chai.use(chaiAsPromised);
 
 describe('onDelete', () => {
-  let onDelete: any;
   let userRecord: any;
 
   before(async () => {
@@ -15,12 +15,11 @@ describe('onDelete', () => {
       email: 'user@example.com',
       password: 'secretPassword'
     };
-    onDelete = require('../src/db/users/onDelete.function');
     userRecord = await admin.auth().createUser(user);
   });
 
   it('should delete the user from the authentication section', () => {
-    const wrapped = test.wrap(onDelete);
+    const wrapped = test.wrap(onDelete.default);
 
     return wrapped(
       {},

functions/test/onUpdate.test.ts

@@ -1,14 +1,12 @@
 import { admin, test } from './util/admin';
 import * as chai from 'chai';
+import * as onUpdate from '../src/db/users/onUpdate.function';
 import 'mocha';
 
 describe('onUpdate', () => {
-  let onUpdate: any;
   let userRecord: any;
 
   before(async () => {
-    onUpdate = require('../src/db/users/onUpdate.function');
-
     const user = {
       uid: '1234',
       email: 'user@example.com',
@@ -24,10 +22,11 @@ describe('onUpdate', () => {
 
   after(async () => {
     await admin.auth().deleteUser(userRecord.uid);
+    test.cleanup();
   });
 
   it('should update the user information in the database', () => {
-    const wrapped = test.wrap(onUpdate);
+    const wrapped = test.wrap(onUpdate.default);
 
     const beforeSnap = test.database.makeDataSnapshot(
       { email: 'user@example.com', isAdmin: false },