Merge branch 'master' into master

Author: TheFocusMan

Docs/articles/Installation/DevKit.md

@@ -4,7 +4,7 @@
 * (Free) source code of Devloppement Kit from [Cosmos on GitHub](https://github.com/CosmosOS/Cosmos)
    * You must clone the repository using Git. For a detailed walkthrough, [see here](https://help.github.com/articles/fork-a-repo/).
    * When following the tutorial, replace *OctoCat* with *CosmosOS* and *Spoon-Knife* with *Cosmos*.
-* (Free) [Visual Studio 2019 Community](https://visualstudio.microsoft.com/vs/)  
+* (Free) [Visual Studio 2022 Community](https://visualstudio.microsoft.com/vs/)  
 * (Free) [InnoSetup QuickStart Kit](http://www.jrsoftware.org/isdl.php#qsp)
    * This is required to build the setup kit which is used to build and install the Visual Studio integration libaries for Cosmos.
     * During install it will ask you about optional components to install. Be sure you check "Install Inno Setup Preprocessor".
@@ -20,11 +20,11 @@
 
 ###  Installation on Windows
 
-* Look in the downloaded sources and run **install-VS2019.bat** with admin privileges (UAC will ask for permission), needed for install in system directories.
+* Look in the downloaded sources and run **install-VS2022.bat** with admin privileges (UAC will ask for permission), needed for install in system directories.
 * When the installation is complete, Visual Studio will automatically open and you may begin programming with your new, modified copy of Cosmos.
 
-## Arguments for the 'install-VS2019.bat' file
-The `install-VS2019.bat` accepts the following parameters :
+## Arguments for the 'install-VS2022.bat' file
+The `install-VS2022.bat` accepts the following parameters :
 
 - `-USERKIT` Run installer for the User Kit only. By default installer build and install Dev Kit.
 - `-RESETHIVE` Reset Visual Studio Experimental Hive after installation.

Tests/Kernels/Cosmos.Compiler.Tests.Bcl.System/System/DoubleTest.cs

@@ -223,6 +223,11 @@ public static void Execute()
             Assert.IsTrue(EqualityHelper.DoublesAreEqual(value, 2.3), "double TryParse returns correct result when it works");
 
             #endregion
+
+            double doubleA = 3;
+            double doubleB = 3;
+
+            Assert.IsTrue(doubleA % doubleB == 0, "Double: 3 % 3 should be equal to 0");
         }
     }
 }

Tests/Kernels/Cosmos.Compiler.Tests.Bcl/Kernel.cs

@@ -52,6 +52,8 @@ protected override void Run()
                 // System.Text
                 StringBuilderTest.Execute();
                 EncodingTest.Execute();
+				
+				GuidTest.Execute();
 
                 TestController.Completed();
             }

Tests/Kernels/Cosmos.Compiler.Tests.Bcl/System/GuidTest.cs

@@ -0,0 +1,53 @@
+using System;
+using System.Linq;
+using System.Threading.Tasks;
+using Cosmos.TestRunner;
+
+namespace Cosmos.Compiler.Tests.Bcl.System
+{
+    class GuidTest
+    {
+
+        public static void Execute()
+        {
+
+            //dont know how else to test this
+
+            Guid testGuid = Guid.NewGuid();
+            Guid testGuid1 = Guid.NewGuid();
+
+            Assert.IsFalse((testGuid == Guid.Empty),"Guid was Empty");
+
+            Assert.IsFalse((testGuid == testGuid1), "Guid was not unique");
+
+            byte[] GuidRFC4122 = testGuid.ToByteArray();
+
+            Assert.IsTrue((GuidRFC4122.Length == 16), "invalid Length");
+
+            Assert.IsTrue((GuidRFC4122[6].ToString("X").StartsWith("4")), $"7th byte invalid (not 4 but '{GuidRFC4122[6].ToString("X")}')");
+
+            bool test9thbyte = false;
+
+            string byte8 = GuidRFC4122[8].ToString("X");
+            if (byte8.StartsWith("8"))
+            {
+                test9thbyte = true;
+            }
+            else if (byte8.StartsWith("9"))
+            {
+                test9thbyte = true;
+            }
+            else if (byte8.StartsWith("A"))
+            {
+                test9thbyte = true;
+            }
+            else if (byte8.StartsWith("B"))
+            {
+                test9thbyte = true;
+            }
+
+            Assert.IsTrue(test9thbyte, "9th byte invalid (not 8,9,A,B)");
+
+        }
+    }
+}

Tests/Kernels/Cosmos.Kernel.Tests.Fat/System.IO/DirectoryTest.cs

@@ -87,6 +87,15 @@ public static void Execute(Debugger mDebugger)
 
             mDebugger.Send("");
 
+            mDebugger.Send("START TEST: Create Directory with a dot");
+            var xDirectoryDot = Directory.CreateDirectory(@"0:\folder.system");
+            Assert.IsTrue(xDirectoryDot != null, "Directory.CreateDirectory with dot failed: Directory is null");
+            bool xDirExists = Directory.Exists(@"0:\folder.system");
+            Assert.IsTrue(xDirExists, "Directory.CreateDirectory with dot failed: Directory doesn't exist after create call");
+            mDebugger.Send("END TEST");
+
+            mDebugger.Send("");
+
             mDebugger.Send("START TEST: Delete a directory:");
             Directory.CreateDirectory(@"0:\TestDir1");
             Assert.IsTrue(Directory.Exists(@"0:\TestDir1"), "TestDir1 wasn't created!");

Tests/Kernels/GraphicTest/Kernel.cs

@@ -192,9 +192,12 @@ private async Task BuildAsync()
 
                     await buildTask.RunAsync(_logger).ConfigureAwait(false);
                 }
+
+                Window.AllTasksCompleted = true;
+
                 if (CloseWhenCompleted)
                 {
-                    Window.Close();
+                    Application.Current.Dispatcher.Invoke(() => Application.Current?.MainWindow?.Close());
                 }
             }
             catch (Exception e)
@@ -207,7 +210,7 @@ private async Task BuildAsync()
 
             if (CloseWhenCompleted)
             {
-                System.Windows.Application.Current.Dispatcher.Invoke(() => System.Windows.Application.Current?.MainWindow?.Close());
+                Application.Current.Dispatcher.Invoke(() => Application.Current?.MainWindow?.Close());
             }
             else
             {

source/Cosmos.Build.Builder/ViewModels/MainWindowViewModel.cs

@@ -1,26 +1,58 @@
 using System;
+using System.ComponentModel;
 using System.Windows;
 using System.Windows.Controls;
+using Wpf.Ui.Common;
 using Wpf.Ui.Controls;
+using Clipboard = System.Windows.Clipboard;
 
 namespace Cosmos.Build.Builder.Views
 {
     public partial class MainWindow : UiWindow
     {
         public bool AppShutdown = true;
+
+        public bool AllTasksCompleted;
+
         public MainWindow()
         {
             InitializeComponent();
-            Loaded += (sender, args) =>
-            {
-                Wpf.Ui.Appearance.Watcher.Watch(this, Wpf.Ui.Appearance.BackgroundType.Mica, true);
-            };
+
+            Loaded += (_, _) => Wpf.Ui.Appearance.Watcher.Watch(this);
         }
 
         private void SectionTextCopyHandler(object sender, System.Windows.Input.MouseButtonEventArgs e)
         {
             Clipboard.SetText(((TextBlock)sender).Text);
         }
+
+        protected override void OnClosing(CancelEventArgs e)
+        {
+            base.OnClosing(e);
+
+            if (!AllTasksCompleted)
+            {
+                e.Cancel = true;
+
+                Wpf.Ui.Controls.MessageBox messageBox = new()
+                {
+                    Content = "You're about to close the builder, however tasks are still running. Do you wish to continue?",
+                    SizeToContent = SizeToContent.Width,
+                    ButtonLeftAppearance = ControlAppearance.Secondary,
+                    ButtonLeftName = "Yes",
+                    ButtonRightAppearance = ControlAppearance.Primary,
+                    ButtonRightName = "No"
+                };
+                messageBox.ButtonLeftClick += (_, _) =>
+                {
+                    messageBox.Close();
+                    Application.Current.Dispatcher.Invoke(() => Application.Current?.MainWindow?.Close());
+                };
+                messageBox.ButtonRightClick += (_, _) => messageBox.Close();
+                messageBox.ShowDialog();
+            }
+        }
+
         protected override void OnClosed(EventArgs e)
         {
             base.OnClosed(e);

source/Cosmos.Build.Builder/Views/MainWindow.xaml.cs

@@ -101,8 +101,8 @@ protected override string GenerateCommandLineCommands()
             }
 
             /* Apply the optimization level that the user chose */
-            xBuilder.AppendSwitch("-O" + OptimizationLevel);
-
+	    if(!String.IsNullOrWhiteSpace(OptimizationLevel) && !String.IsNullOrWhiteSpace(OptimizationLevel))
+            	xBuilder.AppendSwitch($"-O{OptimizationLevel}");
 
             xBuilder.AppendFileNameIfNotNull(InputFile);
 

source/Cosmos.Build.Tasks/Nasm.cs

@@ -73,7 +73,6 @@
         <RemoveBootDebugOutput Condition="'$(RemoveBootDebugOutput)' == ''">ELF</RemoveBootDebugOutput>
 
         <OptimizationLevel Condition="'$(OptimizationLevel)' == ''">1</OptimizationLevel>
-
     </PropertyGroup>
 
     <PropertyGroup>
@@ -231,7 +230,7 @@
               OutputFormat="$(BinFormat)"
               ToolPath="$(NasmToolPath)"
               ToolExe="$(NasmToolExe)"
-	            OptimizationLevel="$(OptimizationLevel)" />
+	      OptimizationLevel="$(OptimizationLevel)"/>
 
     </Target>