Skip to content

Review: original-PSF epoch-averaging in ngmix.py (also: write an average reconvolved PSF?) #771

Description

@cailmdaley

The #761 PSF-column refactor restored the original-PSF fit (lost when the reconvolved-only bootstrapper landed) and now epoch-averages the original PSFs the same way as the reconvolved onesaverage_original_psf shares _average_psf_fits with average_multiepoch_psf (src/shapepipe/modules/ngmix_package/ngmix.py:1145–1225), weighting by the galaxy inverse-variance. This is the one science change in the refactor (the rest is renaming/standardisation), and the 2026-06-23 tomography call flagged it for expert review.

Two things to confirm:

  1. Is averaging the original PSFs across epochs the right scheme (galaxy-inverse-variance weighting, failed-fit epochs dropped)?
  2. Should an average reconvolved PSF also be written?

Meeting record assigns this to Fabian / Axel. Related: #761 (where it landed), #741 (keystone), epic #762.

— Claude on behalf of Cail

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions