Refactor settings; update logic when db is empty; fixing logging and exceptions

Author: CoolCoderCarl

datapath.py

@@ -7,9 +7,9 @@
 import dynaconfig
 import news_db
 
-# Time range for sending messages
-TIME_TO_SEND_START = datetime.now().replace(hour=10, minute=00).strftime("%H:%M")
-TIME_TO_SEND_END = datetime.now().replace(hour=20, minute=00).strftime("%H:%M")
+# Time range for sending messages loaded from settings.toml
+TIME_TO_SEND_START = dynaconfig.settings["TIMINIGS"]["TIME_TO_SEND_START"]
+TIME_TO_SEND_END = dynaconfig.settings["TIMINIGS"]["TIME_TO_SEND_END"]
 
 # Logging
 logging.basicConfig(
@@ -23,9 +23,9 @@
 )
 
 
-API_TOKEN = dynaconfig.settings["API_TOKEN"]
+API_TOKEN = dynaconfig.settings["TELEGRAM"]["API_TOKEN"]
 API_URL = f"https://api.telegram.org/bot{API_TOKEN}/sendMessage"
-CHAT_ID = dynaconfig.settings["CHAT_ID"]
+CHAT_ID = dynaconfig.settings["TELEGRAM"]["CHAT_ID"]
 
 
 def send_news_to_telegram(message):
@@ -49,17 +49,21 @@ def send_news_to_telegram(message):
 
 
 if __name__ == "__main__":
-    data_from_db = news_db.create_connection(news_db.DB_FILE)
+    db_connection = news_db.create_connection(news_db.DB_FILE)
     while True:
-        if data_from_db:
+        if db_connection:
             time.sleep(1)
             current_time = datetime.now().strftime("%H:%M")
             if TIME_TO_SEND_START < current_time < TIME_TO_SEND_END:
-                logging.info(f"Time: {current_time}. Time to send has come !")
-                for news in news_db.send_all_news(data_from_db):
-                    send_news_to_telegram(news)
-                    time.sleep(300)
+                logging.info("Time to send has come !")
+                data_from_db = news_db.send_all_news(db_connection)
+                if len(data_from_db) == 0:
+                    logging.warning("Database is empty !")
+                else:
+                    for news in data_from_db:
+                        send_news_to_telegram(news)
+                        time.sleep(300)
             else:
-                logging.info(f"Time: {current_time}. Still waiting to send.")
+                logging.info("Still waiting to send.")
         else:
-            logging.warning("Looks like database is empty.")
+            logging.error("Connection to db is not exist !")

news_db.py

@@ -7,9 +7,9 @@
 
 import dynaconfig
 
-TIME_TO_PURGE = "00:00"
-
-DB_FILE = Path(f"{dynaconfig.settings['DB_NAME']}")
+# Timing and db name loaded from settings.toml
+TIME_TO_PURGE = dynaconfig.settings["TIMINIGS"]["TIME_TO_PURGE"]
+DB_FILE = Path(f"{dynaconfig.settings['DB']['DB_NAME']}")
 
 # SQL queries
 CREATE_TABLE_SQL = """
@@ -121,19 +121,20 @@ def delete_all_news(conn):
 
 
 if __name__ == "__main__":
-    conn = create_connection(DB_FILE)
-    if DB_FILE.exists():
-        create_table(conn, CREATE_TABLE_SQL)
-
-    while True:
-        CURRENT_TIME = datetime.now().strftime("%H:%M")
-        time.sleep(1)
-        if conn is not None:
-            send_all_news(conn)
-            if CURRENT_TIME == TIME_TO_PURGE:
-                logging.info(f"Time: {CURRENT_TIME}. Time to purge has come !")
-                delete_all_news(conn)
-            else:
-                logging.info(f"Time: {CURRENT_TIME}. Still waiting for purging.")
-        else:
-            logging.error("Error! Cannot create the database connection.")
+    try:
+        conn = create_connection(DB_FILE)
+        if DB_FILE.exists():
+            create_table(conn, CREATE_TABLE_SQL)
+
+        while True:
+            CURRENT_TIME = datetime.now().strftime("%H:%M")
+            time.sleep(1)
+            if conn is not None:
+                send_all_news(conn)
+                if CURRENT_TIME == TIME_TO_PURGE:
+                    logging.info("Time to purge has come !")
+                    delete_all_news(conn)
+                else:
+                    logging.info("Still waiting for purging.")
+    except sqlite3.Error as sql_err:
+        logging.error(f"Cannot create the database connection. Error: {sql_err}")

truth_seeker.py

@@ -7,14 +7,14 @@
 import dynaconfig
 import news_db
 
-# Load variables from settings.toml
-API_KEY = dynaconfig.settings["API_KEY"]
-QUERY = dynaconfig.settings["QUERY"]
+# News API params loaded from settings.toml
+API_KEY = dynaconfig.settings["NEWS_API"]["API_KEY"]
+QUERY = dynaconfig.settings["NEWS_API"]["QUERY"]
+LANGUAGE = dynaconfig.settings["NEWS_API"]["LANGUAGE"]
+TIME_TO_SEARCH = dynaconfig.settings["TIMINGS"]["TIME_TO_SEARCH"]
 
 newsapi = NewsApiClient(api_key=API_KEY)
 
-TIME_TO_SEARCH = "11:10"
-
 
 # Logging
 logging.basicConfig(
@@ -37,10 +37,12 @@ def fetch_info() -> dict:
     # Use to get news from yesterday to current time
     yesterday = date.today() - timedelta(days=1)
     try:
+        logging.info(
+            f"Searching for {QUERY}; most popular; from: {yesterday}; language: {LANGUAGE}"
+        )
         result = newsapi.get_everything(
-            q=QUERY, sort_by="popularity", from_param=yesterday
+            q=QUERY, sort_by="popularity", from_param=yesterday, language=LANGUAGE
         )
-        logging.info(f"Searching for {QUERY}")
         return result
     except ConnectionError as con_err:
         logging.error(con_err)
@@ -74,7 +76,7 @@ def load_to_db(fetch_info: dict):
                 tuple(article_list),
             )
     else:
-        logging.warning("Empty response from API.")
+        logging.warning("Empty response from News API.")
         raise IndexError
 
 
@@ -84,10 +86,10 @@ def load_to_db(fetch_info: dict):
         time.sleep(1)
         # Pull too much info
         if CURRENT_TIME == TIME_TO_SEARCH:
-            logging.info(f"Time: {CURRENT_TIME}. Time to search has come !")
+            logging.info("Time to search has come !")
             try:
                 load_to_db(fetch_info())
             except BaseException as base_err:
                 logging.error(base_err)
         else:
-            logging.info(f"Time: {CURRENT_TIME}. Still waiting for searching.")
+            logging.info("Still waiting for searching.")