Make the test suite green on Windows and deflake the drain bound

The arbiter fixture name must end in .ps1 on Windows or execute_script
rejects it before the injected backend is reached. The git-plumbing suites
skip on native Windows: files land on disk with CRLF and GitPython keeps
repository handles open, breaking diff assertions and temp-dir teardown.

The drain-bound test now waits for the escapee's flood before closing, so
the escapee is provably still writing while close() drains.

Author: gorandodig

tests/test_git_utils.py

@@ -1,4 +1,5 @@
 import os
+import sys
 import tempfile
 from pathlib import Path
 from textwrap import dedent
@@ -19,6 +20,14 @@
 )
 from plain2code_exceptions import InvalidGitRepositoryError
 
+pytestmark = pytest.mark.skipif(
+    sys.platform == "win32",
+    reason=(
+        "Text files land on disk with CRLF and GitPython keeps repository handles open, so diff "
+        "assertions and temp-dir teardown both break; native Windows runs via WSL."
+    ),
+)
+
 
 @pytest.fixture
 def temp_repo():

tests/test_plain_modules.py

@@ -7,6 +7,7 @@
 
 import json
 import os
+import sys
 import tempfile
 from pathlib import Path
 
@@ -22,6 +23,12 @@
 # --------------------------------------------------------------------------
 
 
+uses_git_repo = pytest.mark.skipif(
+    sys.platform == "win32",
+    reason="GitPython keeps repository handles open on Windows, so the temporary build folder cannot be removed; native Windows runs via WSL.",
+)
+
+
 @pytest.fixture
 def fixtures_dir(get_test_data_path):
     return get_test_data_path("data/partial_rendering")
@@ -247,6 +254,7 @@ def test_get_module_render_status_no_rendering(root_module):
     assert root_module.get_module_render_status() == (None, None)
 
 
+@uses_git_repo
 def test_get_module_render_status_returns_from_leaf_when_only_leaf_rendered(root_module):
     leaf = root_module.get_required_module_by_name("pr_leaf")
     _init_build_repo_with_finished_frid(leaf, "1")
@@ -256,6 +264,7 @@ def test_get_module_render_status_returns_from_leaf_when_only_leaf_rendered(root
     assert frid == "1"
 
 
+@uses_git_repo
 def test_get_module_render_status_prefers_most_progressed_module(root_module):
     """The scan walks required_modules in reverse order — the right-most
     rendered module wins."""
@@ -269,6 +278,7 @@ def test_get_module_render_status_prefers_most_progressed_module(root_module):
     assert frid == "1"
 
 
+@uses_git_repo
 def test_get_module_render_status_returns_root_when_root_has_checkpoint(root_module):
     """A checkpoint in the root's own build folder takes precedence over
     required-module checkpoints."""
@@ -290,11 +300,13 @@ def test_is_module_fully_rendered_false_when_nothing_rendered(solo_module):
     assert solo_module.is_module_fully_rendered() is False
 
 
+@uses_git_repo
 def test_is_module_fully_rendered_false_when_only_first_frid_rendered(solo_module):
     _init_build_repo_with_finished_frid(solo_module, "1")
     assert solo_module.is_module_fully_rendered() is False
 
 
+@uses_git_repo
 def test_is_module_fully_rendered_true_when_last_frid_rendered(solo_module):
     # solo module has FRIDs ["1", "2", "3"]; "3" is the last.
     _init_build_repo_with_finished_frid(solo_module, "3")
@@ -425,6 +437,7 @@ def _commit_finished_frid(module: PlainModule, frid: str) -> None:
     )
 
 
+@uses_git_repo
 def test_revert_code_to_frid_reverts_repo_and_trims_metadata(solo_module):
     os.makedirs(solo_module.module_build_folder)
     init_git_repo(solo_module.module_build_folder, module_name=solo_module.module_name)
@@ -443,6 +456,7 @@ def test_revert_code_to_frid_reverts_repo_and_trims_metadata(solo_module):
     assert os.path.exists(solo_module.get_codeplain_folder())
 
 
+@uses_git_repo
 def test_revert_code_to_frid_none_reverts_to_initial_state(solo_module):
     os.makedirs(solo_module.module_build_folder)
     init_git_repo(solo_module.module_build_folder, module_name=solo_module.module_name)
@@ -460,6 +474,7 @@ def test_revert_code_to_frid_none_reverts_to_initial_state(solo_module):
 # --------------------------------------------------------------------------
 
 
+@uses_git_repo
 def test_reconcile_metadata_with_git_trims_metadata_ahead_of_git(solo_module):
     # Simulates the crash window: metadata records FR 2 but git only committed FR 1.
     os.makedirs(solo_module.module_build_folder)
@@ -475,6 +490,7 @@ def test_reconcile_metadata_with_git_trims_metadata_ahead_of_git(solo_module):
     assert metadata["source_hash"] == "abc"
 
 
+@uses_git_repo
 def test_reconcile_metadata_with_git_in_sync_is_noop(solo_module):
     os.makedirs(solo_module.module_build_folder)
     init_git_repo(solo_module.module_build_folder, module_name=solo_module.module_name)
@@ -487,6 +503,7 @@ def test_reconcile_metadata_with_git_in_sync_is_noop(solo_module):
     assert solo_module.load_module_metadata()["functionalities"] == ["fr1", "fr2"]
 
 
+@uses_git_repo
 def test_reconcile_metadata_with_git_no_finished_frid_empties_list(solo_module):
     # Only the initial commit exists (no finished FRID), so the baseline must be emptied.
     os.makedirs(solo_module.module_build_folder)
@@ -498,6 +515,7 @@ def test_reconcile_metadata_with_git_no_finished_frid_empties_list(solo_module):
     assert solo_module.load_module_metadata()["functionalities"] == []
 
 
+@uses_git_repo
 def test_reconcile_metadata_with_git_ignores_foreign_module_frid(solo_module):
     # A repo cloned from a required module carries that module's finished FRID; this
     # module has rendered none of its own, so its baseline must be emptied.
@@ -518,6 +536,7 @@ def test_reconcile_metadata_with_git_ignores_foreign_module_frid(solo_module):
     assert solo_module.load_module_metadata()["functionalities"] == []
 
 
+@uses_git_repo
 def test_reconcile_metadata_with_git_no_metadata_is_noop(solo_module):
     os.makedirs(solo_module.module_build_folder)
     init_git_repo(solo_module.module_build_folder, module_name=solo_module.module_name)

tests/test_render_utils.py

@@ -380,7 +380,9 @@ def test_script_stdin_is_a_terminal_of_its_own_and_never_the_renderers(tmp_path,
 # the cases are driven through an injected backend rather than through a real script:
 # the point is which condition wins, not how it arose.
 
-FAKE_SCRIPT = "arbiter.sh"
+# execute_script() accepts only .ps1 on Windows, and that check runs before the
+# injected backend is reached, so the fake name has to match the platform.
+FAKE_SCRIPT = "arbiter.ps1" if sys.platform == "win32" else "arbiter.sh"
 FAKE_OUTPUT = "fake transcript\n"
 READER_FAILURE = RuntimeError("the master descriptor went away")
 REPLY_DETAIL = "cursor-position reply discarded before delivery"

tests/test_terminal_process.py

@@ -1505,12 +1505,17 @@ def test_the_final_drain_is_bounded_against_a_continuously_writing_escapee(tmp_p
     try:
         process.spawn([script])
         escapee_pid = reported_pid(process, "escapee")
+        # Both channels clear on read; accumulate so the assertions see the whole
+        # transcript. Waiting for the flood also guarantees the escapee is still
+        # writing while close() drains, which is the bound under test.
+        decoded = wait_for_output(process, "x")
+        raw = process.read_raw_output()
         process.terminate_tree(grace=0.1)  # the escapee left the group and survives
         started = time.monotonic()
         process.close()
         elapsed = time.monotonic() - started
-        decoded = process.read_output()
-        raw = process.read_raw_output()
+        decoded += process.read_output()
+        raw += process.read_raw_output()
     finally:
         process.close()
         if escapee_pid is not None and not wait_until_gone(escapee_pid, timeout=0.5):