Removed report_progress tool plus prepare env change to not crash render

Author: VitjanZ

render_machine/actions/agent_fix_conformance_test.py

@@ -49,13 +49,14 @@ def execute(self, render_context: RenderContext, previous_action_payload: Any |
         review_rejection_feedback = (
             previous_action_payload.get("review_rejection_feedback", "") if previous_action_payload else ""
         )
-        # Detect whether we re-entered fixing because the environment preparation
-        # (build/compile) step failed after the previous fix. PrepareTestingEnvironment
-        # returns an ENVIRONMENT_ERROR payload, and the state machine routes that back
-        # here (CONFORMANCE_FIX_APPLIED --HANDLE_ERROR--> CONFORMANCE_TEST_FAILED) without
-        # running the conformance tests. When that happens the latest conformance test
-        # output is stale (the tests never ran), so the agent must be pointed at the
-        # environment preparation output instead.
+        # Detect whether we entered fixing because the environment preparation
+        # (build/compile) step failed — either the first preparation after the tests
+        # were generated or the re-preparation after a previous fix.
+        # PrepareTestingEnvironment returns an ENVIRONMENT_ERROR payload, and the
+        # state machine routes that here (MARK_TESTING_ENVIRONMENT_FAILED -->
+        # CONFORMANCE_TEST_FAILED) without running the conformance tests. When that
+        # happens the latest conformance test output is stale (the tests never ran),
+        # so the agent must be pointed at the environment preparation output instead.
         error = previous_action_payload.get("error") if previous_action_payload else None
         prepare_environment_failed = bool(error and error.get("type") == "ENVIRONMENT_ERROR")
 
@@ -388,7 +389,7 @@ def _update_failure_signature(render_context: RenderContext, ctx, prepare_enviro
             "completely unchanged. Your current hypothesis class is exhausted — do NOT refine it further. "
             "You MUST change strategy: (1) verify your edits reach the executed code (dead-edit axiom), "
             "(2) re-read the failure output from scratch without your prior assumptions, and (3) pick a "
-            "different component or layer to investigate. State your new hypothesis via report_progress "
+            "different component or layer to investigate. State your new hypothesis explicitly "
             "before editing anything."
         )
 

render_machine/actions/prepare_testing_environment.py

@@ -6,10 +6,13 @@
 from render_machine.render_context import RenderContext
 from render_machine.render_types import RenderError
 
+UNRECOVERABLE_ERROR_EXIT_CODES = [69]
+
 
 class PrepareTestingEnvironment(BaseAction):
     SUCCESSFUL_OUTCOME = "testing_environment_prepared"
     FAILED_OUTCOME = "testing_environment_preparation_failed"
+    UNRECOVERABLE_ERROR_OUTCOME = "testing_environment_unrecoverable_error"
 
     def execute(self, render_context: RenderContext, _previous_action_payload: Any | None):
         if (
@@ -21,34 +24,48 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
         console.info(
             f"Running testing environment preparation script {render_context.prepare_environment_script} for build folder {render_context.build_folder}."
         )
-        exit_code, _, preparation_temp_file_path = render_utils.execute_script(
+        exit_code, preparation_issue, preparation_temp_file_path = render_utils.execute_script(
             render_context.prepare_environment_script,
             [render_context.build_folder],
             "Testing Environment Preparation",
             timeout=render_context.test_script_timeout,
             stop_event=render_context.stop_event,
         )
 
-        render_context.conformance_tests_running_context.should_prepare_testing_environment = False
         render_context.script_execution_history.latest_testing_environment_output_path = preparation_temp_file_path
         render_context.script_execution_history.should_update_script_outputs = True
 
-        # Store test output file path in conformance tests context for agents to access
-        # render_context.conformance_tests_running_context.test_output_file_path = preparation_temp_file_path
-
         if exit_code == 0:
+            render_context.conformance_tests_running_context.should_prepare_testing_environment = False
             return self.SUCCESSFUL_OUTCOME, None
-        else:
-            error_message = "Testing environment preparation failed. Please check the preparation script."
-            if preparation_temp_file_path:
-                error_message += f" Full output available at: {preparation_temp_file_path}"
+
+        if exit_code in UNRECOVERABLE_ERROR_EXIT_CODES:
+            console.error(preparation_issue)
             return (
-                self.FAILED_OUTCOME,
+                self.UNRECOVERABLE_ERROR_OUTCOME,
                 RenderError.encode(
-                    message=error_message,
+                    message="Testing environment preparation failed due to problems in the environment setup. Please check your environment or update the preparation script.",
                     error_type="ENVIRONMENT_ERROR",
                     exit_code=exit_code,
                     script=render_context.prepare_environment_script,
-                    output_file=preparation_temp_file_path,
+                    issue=preparation_issue,
                 ).to_payload(),
             )
+
+        # A failed preparation (typically a build/compile error introduced by the
+        # latest code changes) is handled like a failing conformance test: the fix
+        # loop gets the preparation output and corrects the code. The flag stays
+        # armed so the preparation re-runs after the fix is applied.
+        error_message = "Testing environment preparation failed."
+        if preparation_temp_file_path:
+            error_message += f" Full output available at: {preparation_temp_file_path}"
+        payload = RenderError.encode(
+            message=error_message,
+            error_type="ENVIRONMENT_ERROR",
+            exit_code=exit_code,
+            script=render_context.prepare_environment_script,
+            output_file=preparation_temp_file_path,
+        ).to_payload()
+        # The legacy (non-agent) fixer requires the failure text under this key.
+        payload["previous_conformance_tests_issue"] = preparation_issue
+        return self.FAILED_OUTCOME, payload

render_machine/state_machine_config.py

@@ -101,7 +101,8 @@ def get_action_result_triggers_map(self) -> Dict[str, str]:
             RenderConformanceTests.SUCCESSFUL_OUTCOME: triggers.MARK_CONFORMANCE_TESTS_READY,
             AgentRenderConformanceTests.SUCCESSFUL_OUTCOME: triggers.MARK_CONFORMANCE_TESTS_READY,
             PrepareTestingEnvironment.SUCCESSFUL_OUTCOME: triggers.MARK_TESTING_ENVIRONMENT_PREPARED,
-            PrepareTestingEnvironment.FAILED_OUTCOME: triggers.HANDLE_ERROR,
+            PrepareTestingEnvironment.FAILED_OUTCOME: triggers.MARK_TESTING_ENVIRONMENT_FAILED,
+            PrepareTestingEnvironment.UNRECOVERABLE_ERROR_OUTCOME: triggers.HANDLE_ERROR,
             RunConformanceTests.SUCCESSFUL_OUTCOME: triggers.MOVE_TO_NEXT_CONFORMANCE_TEST,
             RunConformanceTests.FAILED_OUTCOME: triggers.MARK_CONFORMANCE_TESTS_FAILED,
             RunConformanceTests.UNRECOVERABLE_ERROR_OUTCOME: triggers.HANDLE_ERROR,
@@ -399,9 +400,19 @@ def get_transitions(self, render_context: RenderContext) -> List[Dict[str, Any]]
                 "trigger": triggers.MARK_TESTING_ENVIRONMENT_PREPARED,
                 "dest": f"{States.IMPLEMENTING_FRID.value}_{States.PROCESSING_CONFORMANCE_TESTS.value}_{States.CONFORMANCE_TEST_ENV_PREPARED.value}",
             },
+            # A failed environment preparation (typically a build/compile error) is
+            # treated like a failing conformance test: route into the fix loop with
+            # the preparation output instead of failing the render. Covers both the
+            # first preparation after the tests are generated and the re-preparation
+            # after a fix is applied.
+            {
+                "source": f"{States.IMPLEMENTING_FRID.value}_{States.PROCESSING_CONFORMANCE_TESTS.value}_{States.CONFORMANCE_TEST_GENERATED.value}",
+                "trigger": triggers.MARK_TESTING_ENVIRONMENT_FAILED,
+                "dest": f"{States.IMPLEMENTING_FRID.value}_{States.PROCESSING_CONFORMANCE_TESTS.value}_{States.CONFORMANCE_TEST_FAILED.value}",
+            },
             {
                 "source": f"{States.IMPLEMENTING_FRID.value}_{States.PROCESSING_CONFORMANCE_TESTS.value}_{States.CONFORMANCE_FIX_APPLIED.value}",
-                "trigger": triggers.HANDLE_ERROR,
+                "trigger": triggers.MARK_TESTING_ENVIRONMENT_FAILED,
                 "dest": f"{States.IMPLEMENTING_FRID.value}_{States.PROCESSING_CONFORMANCE_TESTS.value}_{States.CONFORMANCE_TEST_FAILED.value}",
             },
             # Review APPROVED: tests already pass, so continue the test orchestration

render_machine/triggers.py

@@ -19,6 +19,7 @@
 START_NEW_REFACTORING_ITERATION = "start_new_refactoring_iteration"
 MARK_CONFORMANCE_TESTS_READY = "mark_conformance_tests_ready"
 MARK_TESTING_ENVIRONMENT_PREPARED = "mark_testing_environment_prepared"
+MARK_TESTING_ENVIRONMENT_FAILED = "mark_testing_environment_failed"
 MARK_CONFORMANCE_TESTS_FAILED = "mark_conformance_tests_failed"
 MOVE_TO_NEXT_CONFORMANCE_TEST = "move_to_next_conformance_test"
 MARK_ALL_CONFORMANCE_TESTS_PASSED = "mark_all_conformance_tests_passed"