feat(parsing): emit conformance script warning in dry-run as well

Author: zanjonke

plain2code.py

@@ -158,31 +158,34 @@ def _check_connection(codeplainAPI: codeplain_api.CodeplainAPI):
         )
 
 
-def warn_if_acceptance_tests_without_conformance_script(plain_module, args) -> None:
+def warn_acceptance_tests_without_conformance_script(module_names_with_acceptance_tests, args) -> None:
     """Warn when acceptance tests are specified but no conformance tests script is configured.
 
     Acceptance tests are treated as conformance tests, so a conformance tests script is required
     to actually run them. Without it, the acceptance tests cannot be executed.
     """
-    if args.conformance_tests_script:
+    if args.conformance_tests_script or not module_names_with_acceptance_tests:
         return
 
-    modules_with_acceptance_tests = [
-        module
-        for module in plain_module.all_required_modules + [plain_module]
-        if plain_spec.has_acceptance_tests(module.plain_source)
-    ]
-    if not modules_with_acceptance_tests:
-        return
-
-    module_names = ", ".join(module.module_name for module in modules_with_acceptance_tests)
+    module_names = ", ".join(module_names_with_acceptance_tests)
     console.warning(
         f"Acceptance tests were found ({module_names}) but no conformance tests script is configured. "
         "Acceptance tests are treated as conformance tests and require a conformance tests script "
         "(--conformance-tests-script or 'conformance_tests_script' in config) to be executed."
     )
 
 
+def warn_if_acceptance_tests_without_conformance_script(plain_module, args) -> None:
+    """Warn when any loaded module (including required modules) defines acceptance tests
+    but no conformance tests script is configured."""
+    module_names_with_acceptance_tests = [
+        module.module_name
+        for module in plain_module.all_required_modules + [plain_module]
+        if plain_spec.has_acceptance_tests(module.plain_source)
+    ]
+    warn_acceptance_tests_without_conformance_script(module_names_with_acceptance_tests, args)
+
+
 def render(args, run_state: RunState, event_bus: EventBus, default_log_level: str = "INFO"):  # noqa: C901
     template_dirs = file_utils.get_template_directories(args.filename, args.template_dir, DEFAULT_TEMPLATE_DIRS)
 
@@ -350,9 +353,13 @@ def main():  # noqa: C901
 
             if args.dry_run:
                 console.info("Printing dry run output...\n")
-                _, plain_source_tree, _ = plain_file.plain_file_parser(args.filename, template_dirs)
+                module_name, plain_source_tree, _ = plain_file.plain_file_parser(args.filename, template_dirs)
                 render_range = plain_spec.compute_render_range(args, plain_source_tree)
                 print_dry_run_output(plain_source_tree, render_range)
+                module_names_with_acceptance_tests = (
+                    [module_name] if plain_spec.has_acceptance_tests(plain_source_tree) else []
+                )
+                warn_acceptance_tests_without_conformance_script(module_names_with_acceptance_tests, args)
                 return
         except Exception as e:
             console.error(f"Error: {str(e)}")

tests/test_plain2code.py

@@ -68,3 +68,31 @@ def test_warns_when_acceptance_tests_only_in_required_module():
     mock_console.warning.assert_called_once()
     warning_message = mock_console.warning.call_args.args[0]
     assert "dependency" in warning_message
+
+
+def test_core_helper_warns_with_module_names_and_no_script():
+    args = Namespace(conformance_tests_script=None)
+
+    with patch("plain2code.console") as mock_console:
+        plain2code.warn_acceptance_tests_without_conformance_script(["top"], args)
+
+    mock_console.warning.assert_called_once()
+    assert "top" in mock_console.warning.call_args.args[0]
+
+
+def test_core_helper_no_warning_with_empty_module_names():
+    args = Namespace(conformance_tests_script=None)
+
+    with patch("plain2code.console") as mock_console:
+        plain2code.warn_acceptance_tests_without_conformance_script([], args)
+
+    mock_console.warning.assert_not_called()
+
+
+def test_core_helper_no_warning_when_conformance_script_configured():
+    args = Namespace(conformance_tests_script="run_conformance_tests.sh")
+
+    with patch("plain2code.console") as mock_console:
+        plain2code.warn_acceptance_tests_without_conformance_script(["top"], args)
+
+    mock_console.warning.assert_not_called()