Skip to content

Commit 06c90be

Browse files
committed
chore: run the probe from its own branch
A workflow is only offered as a manual run once it is on the default branch, and this one does not belong there. Pushing the branch now runs it, which is all it needs to measure from a runner. The Actions page can re-run it without a new commit. A push carries no inputs, so each parameter falls back to its default.
1 parent 4c1ce7d commit 06c90be

1 file changed

Lines changed: 17 additions & 6 deletions

File tree

‎.github/workflows/probe-connection-hold.yml‎

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,20 @@
11
# Measure how long a quiet connection to the render service survives, from a CI runner.
22
#
33
# The equipment under suspicion is the runner's own outbound network, so this has to run
4-
# here rather than on a developer machine. It is started by hand: it holds connections open
5-
# for several minutes at a time and has no reason to run on a push.
4+
# here rather than on a developer machine.
65
#
7-
# It needs the /connection_hold endpoint, which lives on the testing deployment only.
6+
# It holds connections open for several minutes at a time, so it runs only for the branch
7+
# it belongs to and never for any other. It needs the /connection_hold endpoint, which
8+
# lives on the testing deployment only.
89
name: Probe connection hold
910

1011
on:
12+
# A workflow is only offered as a manual run once it is on the default branch, and this
13+
# one is not meant to live there. Pushing the branch runs it, which is enough to measure
14+
# from a runner. Re-run it from the Actions page to measure again without a new commit.
15+
push:
16+
branches:
17+
- chore/probe-connection-hold
1118
workflow_dispatch:
1219
inputs:
1320
api:
@@ -50,11 +57,15 @@ jobs:
5057
- name: Probe
5158
env:
5259
CODEPLAIN_API_KEY: ${{ secrets.CODEPLAIN_API_KEY }}
60+
# A push carries no inputs, so each one falls back to its default.
61+
API: ${{ inputs.api || 'https://api.test.codeplain.ai' }}
62+
DELAYS: ${{ inputs.delays || '60,180,240,300,420,540' }}
63+
REPEATS: ${{ inputs.repeats || '3' }}
5364
run: |
5465
python ops/probe_connection_hold.py \
55-
--api "${{ inputs.api }}" \
56-
--delays "${{ inputs.delays }}" \
57-
--repeats "${{ inputs.repeats }}" \
66+
--api "$API" \
67+
--delays "$DELAYS" \
68+
--repeats "$REPEATS" \
5869
--json-out probe-results.json
5970
6071
- name: Keep the measurements

0 commit comments

Comments
 (0)