Remove the terminal-driving helper for generated tests

The helper let a generated conformance or acceptance test drive its
target through the controlling terminal. Attaching it to an execution
suppressed the end-of-file the terminal is otherwise given at spawn, on
the basis that something would answer the target's reads instead.

That trade was applied to every conformance and acceptance execution,
while only a test written against the helper ever made it good. Tests
that never used it -- nearly all of them -- ran against a terminal whose
input simply never ended, so any target reading standard input blocked
until the execution timeout. The fix loop then read that timeout as a
defect in the generated code and patched against it until the render was
abandoned. An interactive command-line application is the worst case:
its first prompt is unanswerable, so no functionality after it can pass.

Weighed against that, the capability was used once in roughly thirty
renders. Removing it deletes the broker, its wire protocol, the helper
executable, the capability descriptor, and the portability audit that
existed only to keep the helper out of delivered code -- along with the
outstanding Windows transport work none of it can ship without.

The pseudoterminal backend stays. Giving the target a real terminal is
what makes isatty() true and what interactive programs need to start at
all; that is independent of anything driving the terminal from outside.
The spawn-time end-of-file becomes unconditional, matching the behaviour
the pipe backend has always had, and quiet-target re-delivery now applies
uniformly rather than only where no driver was attached.

Tests that need to drive an interactive program can do so with an
established pseudoterminal library, which also leaves the generated suite
runnable outside this renderer.

Claude-Session: https://claude.ai/code/session_01RwffYaMySLGNKhGyXzDLGG

Author: gorandodig

codeplain_REST_api.py

@@ -322,7 +322,6 @@ def render_conformance_tests(
         conformance_tests_json,
         all_acceptance_tests,
         run_state: RunState,
-        platform_test_runtime: Optional[dict] = None,
     ):
         endpoint_url = f"{self.api_url}/render_conformance_tests"
         headers = {"X-API-Key": self.api_key, "Content-Type": "application/json"}
@@ -341,9 +340,6 @@ def render_conformance_tests(
             "all_acceptance_tests": all_acceptance_tests,
         }
 
-        if platform_test_runtime is not None:
-            payload["platform_test_runtime"] = platform_test_runtime
-
         response = self.post_request(endpoint_url, headers, payload, run_state)
         return response["patched_response_files"], response["conformance_tests_plan_summary_string"]
 
@@ -387,7 +383,6 @@ def fix_conformance_tests_issue(
         current_testing_frid_high_level_implementation_plan: Optional[str],
         conflicting_requirements_count: int,
         run_state: RunState,
-        platform_test_runtime: Optional[dict] = None,
         stalled_reason: Optional[str] = None,
     ):
         endpoint_url = f"{self.api_url}/fix_conformance_tests_issue"
@@ -415,9 +410,6 @@ def fix_conformance_tests_issue(
         if acceptance_tests is not None:
             payload["acceptance_tests"] = acceptance_tests
 
-        if platform_test_runtime is not None:
-            payload["platform_test_runtime"] = platform_test_runtime
-
         # Sent only once the loop has stopped moving. Omitted otherwise, so an
         # ordinary fix request is byte-identical to what it was.
         if stalled_reason is not None:
@@ -437,7 +429,6 @@ def render_acceptance_tests(
         required_modules,
         acceptance_test,
         run_state: RunState,
-        platform_test_runtime: Optional[dict] = None,
     ):
         """
         Renders acceptance tests based on the provided parameters.
@@ -477,9 +468,6 @@ def render_acceptance_tests(
             "acceptance_test": acceptance_test,
         }
 
-        if platform_test_runtime is not None:
-            payload["platform_test_runtime"] = platform_test_runtime
-
         return self.post_request(endpoint_url, headers, payload, run_state)
 
     def analyze_rendering(

plain2code_tty.py

@@ -41,7 +41,6 @@ dev = [
 
 [project.scripts]
 codeplain = "plain2code:main"
-codeplain-tty = "plain2code_tty:main"
 
 # Derive the version from the git tag (e.g. v0.3.8 -> 0.3.8). The version is
 # baked into the package metadata at build time; system_config.py reads it back

pyproject.toml

@@ -21,7 +21,7 @@
 * The job is a stronger containment than a POSIX process group. It survives `setpgid`-style
   escapes and the kernel enforces it, whereas PTY hangup delivers a signal a target may
   ignore.
-* There is no synthetic end-of-file. POSIX injects `VEOF` when no input driver is attached;
+* There is no synthetic end-of-file. POSIX injects `VEOF` at spawn;
   ConPTY has no parent-side equivalent that keeps the input channel open, and the channel
   has to stay open for the graceful control byte and for terminal-query replies. A script
   that reads input therefore blocks until the execution timeout rather than seeing EOF.
@@ -66,7 +66,6 @@
     TERMINAL_ROWS,
     InputWriteResult,
     TerminalEnvironmentError,
-    TerminalInputDriver,
     TerminalProcess,
     TerminalProcessError,
     terminal_child_environment,
@@ -165,8 +164,8 @@
 # unlike the other backends it cannot hand the target end-of-file, so a script that reads
 # terminal input really does block until the execution timeout.
 NO_INPUT_NOTE = (
-    " No input driver was attached to the script's terminal, and on Windows the terminal carries "
-    "no synthetic end-of-file, so a script that waits for terminal input blocks until the timeout."
+    " On Windows the terminal carries no synthetic end-of-file, so a script that waits for "
+    "terminal input blocks until the timeout."
 )
 
 
@@ -1070,7 +1069,6 @@ def spawn(
         env: Optional[dict] = None,
         terminal_size: Tuple[int, int] = (TERMINAL_COLUMNS, TERMINAL_ROWS),
         stop_event: Optional[threading.Event] = None,
-        input_driver: Optional[TerminalInputDriver] = None,
         spawn_timeout: float = HANDSHAKE_TIMEOUT_SECONDS,
     ) -> None:
         if self._spawned:

render_machine/_conpty.py

@@ -44,7 +44,6 @@
     TERMINAL_ROWS,
     InputDisposition,
     InputWriteResult,
-    TerminalInputDriver,
     TerminalLaunchError,
     TerminalProcess,
     child_environment,
@@ -111,7 +110,6 @@ def spawn(
         env: Optional[dict] = None,
         terminal_size: Tuple[int, int] = (TERMINAL_COLUMNS, TERMINAL_ROWS),
         stop_event: Optional[threading.Event] = None,
-        input_driver: Optional[TerminalInputDriver] = None,
     ) -> None:
         if self._spawned:
             raise RuntimeError("LegacyPipeProcess instances are single-use")

render_machine/_legacy_pipe.py

@@ -52,7 +52,6 @@
     InputDisposition,
     InputWriteResult,
     TerminalEnvironmentError,
-    TerminalInputDriver,
     TerminalLaunchError,
     TerminalProcess,
     TerminalProcessError,
@@ -477,7 +476,6 @@ def __init__(self) -> None:
         self._spawned = False
         self._closed = False
         self._acked = False
-        self._input_driver: Optional[TerminalInputDriver] = None
 
         self._bundle: Optional[_ReaderBundle] = None
         self._reader: Optional[threading.Thread] = None
@@ -513,15 +511,13 @@ def spawn(
         env: Optional[dict] = None,
         terminal_size: Tuple[int, int] = (TERMINAL_COLUMNS, TERMINAL_ROWS),
         stop_event: Optional[threading.Event] = None,
-        input_driver: Optional[TerminalInputDriver] = None,
         handshake_timeout: float = HANDSHAKE_TIMEOUT_SECONDS,
     ) -> None:
         """Allocates the terminal, launches the target, and returns once it is running."""
         if self._spawned:
             raise RuntimeError("PosixPtyProcess instances are single-use")
         self._spawned = True
         self._stop_event = stop_event if stop_event is not None else threading.Event()
-        self._input_driver = input_driver
         deadline = time.monotonic() + handshake_timeout
         try:
             self._check_cancelled()
@@ -775,11 +771,10 @@ def _advance_handshake(self, parser: _HandshakeParser, status_r: int, deadline:
         return False
 
     def _acknowledge(self, deadline: float) -> None:
-        """Records the group, delivers the no-driver VEOF, and only then releases the target."""
+        """Records the group, delivers the VEOF, and only then releases the target."""
         assert self._proc is not None
         self._pgid = self._proc.pid  # recorded BEFORE the target can run
-        if self._input_driver is None:
-            self._inject_veof(deadline)
+        self._inject_veof(deadline)
         self._pre_ack_hook()
         self._acked = True
         ack_w = self._ack_w

render_machine/_posix_pty.py

@@ -3,17 +3,13 @@
 import file_utils
 from plain2code_console import SUCCESS_COLOR, console
 from render_machine.actions.base_action import BaseAction
-from render_machine.platform_test_audit import audit_build_folder
 from render_machine.render_context import RenderContext
 
 
 class CreateDist(BaseAction):
     SUCCESSFUL_OUTCOME = "dist_created"
 
     def execute(self, render_context: RenderContext, _previous_action_payload: Any | None):
-        # The final portability audit: a build that references Codeplain's private test
-        # runtime is never published or copied.
-        audit_build_folder(render_context.build_folder)
         # Copy build and conformance tests folders to output folders if specified
         if render_context.copy_build:
             file_utils.copy_folder_to_output(

render_machine/actions/create_dist.py

@@ -9,7 +9,6 @@
 from render_machine.actions.base_action import BaseAction
 from render_machine.fix_loop_metrics import CONFORMANCE_LOOP, STRATEGY_SWITCH_PREFIX, stalled_reason
 from render_machine.implementation_code_helpers import ImplementationCodeHelpers
-from render_machine.platform_test_runtime import advertised_platform_test_runtime
 from render_machine.render_context import RenderContext
 from render_machine.render_types import RenderError, TestExecutionPhase
 
@@ -217,7 +216,6 @@ def execute(self, render_context: RenderContext, previous_action_payload: Any |
             render_context.conformance_tests_running_context.current_testing_frid_high_level_implementation_plan,
             render_context.conformance_tests_running_context.conflicting_requirement_count,
             run_state=render_context.run_state,
-            platform_test_runtime=advertised_platform_test_runtime(),
             stalled_reason=stall_context,
         )
         code_diff_files_content = {}

render_machine/actions/fix_conformance_test.py

@@ -7,7 +7,6 @@
 from plain2code_console import console
 from render_machine.actions.base_action import BaseAction
 from render_machine.implementation_code_helpers import ImplementationCodeHelpers
-from render_machine.platform_test_runtime import advertised_platform_test_runtime
 from render_machine.render_context import RenderContext
 from render_machine.render_types import AcceptanceTestPhase, TestExecutionPhase
 
@@ -127,7 +126,6 @@ def _render_conformance_tests(self, render_context: RenderContext):
             ),
             all_acceptance_tests,
             run_state=render_context.run_state,
-            platform_test_runtime=advertised_platform_test_runtime(),
         )
 
         render_context.conformance_tests_running_context.current_testing_frid_high_level_implementation_plan = (
@@ -180,7 +178,6 @@ def _render_acceptance_test(self, render_context: RenderContext):
             render_context.get_required_modules_functionalities(),
             acceptance_test,
             run_state=render_context.run_state,
-            platform_test_runtime=advertised_platform_test_runtime(),
         )
         conformance_tests_folder_name = (
             render_context.conformance_tests_running_context.get_current_conformance_test_folder_name()

render_machine/actions/render_conformance_tests.py

@@ -5,7 +5,6 @@
 from plain2code_console import console
 from render_machine.actions.base_action import BaseAction
 from render_machine.fix_loop_metrics import CONFORMANCE_LOOP, report_fix_loop_attempt
-from render_machine.platform_test_runtime import platform_test_runtime_available
 from render_machine.render_context import RenderContext
 from render_machine.render_types import RenderError
 
@@ -50,10 +49,6 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
             module=render_context.conformance_tests_running_context.current_testing_module_name,
             timeout=render_context.test_script_timeout,
             stop_event=render_context.stop_event,
-            # Conformance (and the acceptance tests that extend the same suite) may drive
-            # the target's terminal through codeplain-tty; unit tests and environment
-            # preparation never get the runtime.
-            platform_test_runtime=platform_test_runtime_available(),
         )
         render_context.script_execution_history.latest_conformance_test_output_path = (
             conformance_tests_temp_log_file_path