Skip to content

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Hashtag link doesn't work correctly#190

Open
RahwaZeslusHaile wants to merge 1 commit into
CodeYourFuture:mainfrom
RahwaZeslusHaile:hashtag-link
Open

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Hashtag link doesn't work correctly#190
RahwaZeslusHaile wants to merge 1 commit into
CodeYourFuture:mainfrom
RahwaZeslusHaile:hashtag-link

Conversation

@RahwaZeslusHaile

Copy link
Copy Markdown

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Hashtag link doesn't work correctly

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

##Feat: Add rebloom functionality

Summary

Improved hashtag regex to match only word characters

Changes

  • Improved hashtag regex to match only word characters (no trailing spaces/punctuation)
  • URI-encode hashtag in links for safe URL handling
  • Make hashtagView async and await API response before rendering to ensure blooms populate

Please review my work — thank you!

@RahwaZeslusHaile

Copy link
Copy Markdown
Author

@OracPrime I’ve created a new pull request to start from scratch and keep the changes specific to this branch. Apologies for the late update, and thank you for your time.

@RahwaZeslusHaile RahwaZeslusHaile added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 5, 2026

@OracPrime OracPrime left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow response - dropped the ball on this one. It looks good though

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants