merge with TW upstream

Author: Titanium2099

.github/workflows/node.js.yml

@@ -8,13 +8,13 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+    - uses: actions/checkout@v4
       with:
         persist-credentials: false
     - name: Install Node.js
-      uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af
+      uses: actions/setup-node@v4
       with:
-        node-version: 20
+        node-version: 22
         cache: npm
     - run: npm ci
     - run: npm run lint

src/SoundBank.js

@@ -98,6 +98,29 @@ class SoundBank {
         return this.soundEffects.get(sound);
     }
 
+    /**
+     * Remove a single sound player and release its resources.
+     * @param {string} soundId - the id of the sound player to remove
+     */
+    removeSoundPlayer (soundId) {
+        const player = this.soundPlayers[soundId];
+        if (player) {
+            player.dispose();
+            delete this.soundPlayers[soundId];
+        }
+
+        const effects = this.soundEffects.get(soundId);
+        if (effects) {
+            if (player) {
+                effects.removeSoundPlayer(player);
+            }
+            effects.dispose();
+            this.soundEffects.delete(soundId);
+        }
+
+        this.playerTargets.delete(soundId);
+    }
+
     /**
      * Play a sound.
      * @param {Target} target - Target to play for

src/effects/EffectChain.js

@@ -88,7 +88,7 @@ class EffectChain {
      * @param {SoundPlayer} soundPlayer - a sound player to stop managing
      */
     removeSoundPlayer (soundPlayer) {
-        this._soundPlayers.remove(soundPlayer);
+        this._soundPlayers.delete(soundPlayer);
     }
 
     /**