Merge pull request #2196 from CodeNow/SAN-6097

SAN-6097

Author: damienrunnable

client/directives/components/mirrorDockerfile/addDockerfileDirective.js

@@ -4,8 +4,6 @@ require('app')
   .directive('addDockerfile', addDockerfile);
 
 function addDockerfile(
-  $q,
-  $timeout,
   fetchRepoDockerfile,
   doesDockerfileExist
 ) {
@@ -20,6 +18,8 @@ function addDockerfile(
       fileType: '@'
     },
     link: function ($scope, elem, attrs, MDC) {
+      $scope.MDC = MDC;
+
       var COMPOSE_DEFAULT = 'docker-compose.yml';
       var COMPOSE_TEST_DEFAULT = 'docker-compose.test.yml';
       var DOCKER_DEFAULT = 'Dockerfile';

client/directives/components/mirrorDockerfile/addDockerfileView.jade

@@ -15,7 +15,7 @@ form(
         dockerfile-exists-validator = "{{fileType}}"
         full-repo = "fullRepo"
         id = "add-dockerfile-input"
-        ng-disabled = "state.dockerFileAdded || $root.featureFlags.composeEditing"
+        ng-disabled = "state.dockerFileAdded || $root.featureFlags.composeEditing || MDC.isSaving()"
         ng-model = "newDockerfile"
         ng-model-options = "{ debounce: { 'default': 100, 'blur': 0 } }"
         placeholder = "{{ fileName }}"

client/directives/components/mirrorDockerfile/composeFilePath.js

@@ -21,6 +21,8 @@ function composeFilePath(
       fullRepo: '='
     },
     link: function ($scope, elem, attr, MDC) {
+      $scope.MDC = MDC;
+
       MDC.state.configurationMethod = 'dockerComposeFile';
       $scope.dockerComposeState = MDC.state;
       $scope.dockerfile = {};

client/directives/components/mirrorDockerfile/mirrorDockerfileController.js

@@ -6,7 +6,6 @@ require('app')
 function MirrorDockerfileController(
   $q,
   $rootScope,
-  $timeout,
   errs,
   doesDockerfileExist,
   fetchRepoDockerfile,
@@ -74,5 +73,9 @@ function MirrorDockerfileController(
         }
       });
   };
+
+  MDC.isSaving = function () {
+    return $rootScope.isLoading.newContainerSingleRepo || $rootScope.isLoading.creatingDockerCompose;
+  };
 }
 

client/directives/components/newContainer/forms/compose/composeFilePathView.jade

@@ -6,6 +6,7 @@
         ng-disabled = "$root.featureFlags.composeEditing"
         ng-model = "pathEnabled"
         type = "checkbox"
+        ng-disabled = "MDC.isSaving()"
       )
       .toggle-group.toggle-sm
 
@@ -41,7 +42,7 @@
       - Copy: "Select a Container"
     fancy-select.btn-md.white(
       disabled
-      ng-disabled = "loadingFile || !dockerComposeTestServices.length"
+      ng-disabled = "loadingFile || !dockerComposeTestServices.length || MDC.isSaving()"
       ng-required = "true"
       spinner-flag = "loadingFile"
       value = "dockerComposeState.testReporter"

client/directives/components/newContainer/forms/nameNewServiceView.jade

@@ -13,6 +13,7 @@ label
       required
       spellcheck = "false"
       unique-validator = "NCC.state.namesForAllInstances"
+      ng-disabled = "NCC.isSaving()"
     )
     svg.iconnables.icons-check(
       ng-if = "NCC.nameForm.$valid"

client/directives/components/newContainer/forms/setupMethodView.jade

@@ -17,7 +17,7 @@ label.grid-block.align-center.btn.btn-radio(
 label.grid-block.align-center.btn.btn-radio(
   data-event-name = "Selected Compose Setup"
   ng-class = "{'active': NCC.state.dockerFileTab === 'compose'}"
-  ng-click = "NCC.state.dockerFileTab = 'compose'; NCC.state.configurationMethod = 'dockerComposeFile'"
+  ng-click = "NCC.setToComposeTab()"
 )
   svg.grid-block.shrink.btn.btn-xs.btn-icon.btn-add.iconnables.icons-check
     use(
@@ -30,7 +30,7 @@ label.grid-block.align-center.btn.btn-radio(
 label.grid-block.align-center.btn.btn-radio(
   data-event-name = "Selected Dockerfile Setup"
   ng-class = "{'active': NCC.state.dockerFileTab === 'dockerfile'}"
-  ng-click = "NCC.state.dockerFileTab = 'dockerfile'; NCC.state.configurationMethod = 'dockerfile'"
+  ng-click = "NCC.setToDockerTab()"
   ng-if = "!$root.featureFlags.kubernetes"
 )
   svg.grid-block.shrink.btn.btn-xs.btn-icon.btn-add.iconnables.icons-check

client/directives/components/newContainer/newContainerController.js

@@ -396,6 +396,24 @@ function NewContainerController(
             (NCC.state.types.stage ? NCC.state.dockerComposeFile : NCC.state.types.test))));
   };
 
+  NCC.isSaving = function () {
+    return $rootScope.isLoading.newContainerSingleRepo || $rootScope.isLoading.creatingDockerCompose;
+  };
+
+  NCC.setToComposeTab = function () {
+    if (!NCC.isSaving()) {
+      NCC.state.dockerFileTab = 'compose';
+      NCC.state.configurationMethod = 'dockerComposeFile';
+    }
+  };
+
+  NCC.setToDockerTab = function () {
+    if (!NCC.isSaving()) {
+      NCC.state.dockerFileTab = 'dockerfile';
+      NCC.state.configurationMethod = 'dockerfile';
+    }
+  };
+
   NCC.populateComposeErrorMessage = function (errorMsg) {
     var err = /ValidationError(.*)/.exec(errorMsg);
     if (err) {