SAN-6094 Fixing bug where i thought we were using epoche and were using 0 BCE instead.

Author: damienrunnable

client/services/calculateHistoricalTestResults.js

@@ -6,6 +6,7 @@ require('app')
 var PASSED = 'passed';
 var FAILED = 'failed';
 var UNKNOWN = 'unknown';
+var jesusBirthday = '0001-01-01T00:00:00Z';
 
 function calculateHistoricalTestResult(
   keypather
@@ -22,15 +23,13 @@ function calculateHistoricalTestResult(
     },
     addResults: function (tests) {
       tests.forEach(function(test) {
-        if (test && keypather.get(test, 'build.stop.valueOf()') !== 0) {
+        if (test && keypather.get(test, 'build.stop') !== jesusBirthday) {
           if (keypather.get(test, 'build.failed') || keypather.get(test, 'application.exitCode') > 0) {
             test.testState = FAILED;
-          } else if (keypather.get(test,'application.exitCode') === 0 &&
-              keypather.get(test,'application.stop.valueOf()') !== 0) {
+          } else if (keypather.get(test,'application.exitCode') === 0 && keypather.get(test,'application.stop') !== jesusBirthday) {
             test.testState =  PASSED;
           }
         }
-
         if (!test.testState) {
           test.testState = UNKNOWN;
         }

test/unit/directives/components/lists/branchTestListController.unit.js

@@ -18,6 +18,8 @@ describe('BranchTestListController'.bold.underline.blue, function () {
   var newCommit;
   var appCodeVersion;
 
+  var jesusBirthday = '0001-01-01T00:00:00Z';
+
   function initialize() {
     appCodeVersion = {
       attrs: {
@@ -74,7 +76,7 @@ describe('BranchTestListController'.bold.underline.blue, function () {
       {
         commitSha: '1',
         build: {
-          stop: new Date(0),
+          stop: jesusBirthday,
           failed: false
         }
       },
@@ -103,7 +105,7 @@ describe('BranchTestListController'.bold.underline.blue, function () {
         },
         application: {
           exitCode: 0,
-          stop: new Date(0)
+          stop: jesusBirthday
         }
       },
       {
@@ -178,13 +180,13 @@ describe('BranchTestListController'.bold.underline.blue, function () {
       $scope.$digest();
       // No test found
       expect(branch.commits.models[0].test).to.equal(null);
-      // Test found but build exit time of epoch
+      // Test found but build exit time of jessus birthday
       expect(branch.commits.models[1].test).to.equal('unknown');
       // Build failed is true
       expect(branch.commits.models[2].test).to.equal('failed');
       // // Build passed but exit code > 0
       expect(branch.commits.models[3].test).to.equal('failed');
-      // Application stop is epoch
+      // Application stop is jessus birthday
       expect(branch.commits.models[4].test).to.equal('unknown');
       expect(branch.commits.models[5].test).to.equal('passed');
     });

test/unit/services/calculateHistoricalTestResults.unit.js

@@ -3,6 +3,7 @@
 describe('calculateHistoricalTestResult'.bold.underline.blue, function () {
   var calculateHistoricalTestResult;
   var keypather;
+  var jesusBirthday = '0001-01-01T00:00:00Z';
 
   function setup() {
     angular.mock.module('app');
@@ -21,7 +22,7 @@ describe('calculateHistoricalTestResult'.bold.underline.blue, function () {
     it('addResults build stop epoch', function () {
       var tests = [{
         build: {
-          stop: new Date(0),
+          stop: jesusBirthday,
           failed: false
         },
         application: {
@@ -74,7 +75,7 @@ describe('calculateHistoricalTestResult'.bold.underline.blue, function () {
         },
         application: {
           exitCode: 0,
-          stop: new Date(0)
+          stop: jesusBirthday
         }
       }];
       calculateHistoricalTestResult.addResults(tests);