SAN-6074 Code review comment

damienrunnable · damienrunnable · commit d3449ac3e15c · 2017-04-17T17:02:54.000-07:00
diff --git a/client/services/calculateHistoricalTestResults.js b/client/services/calculateHistoricalTestResults.js
@@ -31,8 +31,10 @@ function calculateHistoricalTestResult(
         if (keypather.get(test, 'build.stop') !== jesusBirthday) {
           if (keypather.get(test, 'build.failed') || keypather.get(test, 'application.exitCode') > 0) {
             test.testState = FAILED;
+            return;
           } else if (keypather.get(test,'application.exitCode') === 0 && keypather.get(test,'application.stop') !== jesusBirthday) {
             test.testState =  PASSED;
+            return;
           }
         }
       });

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,10 @@ function calculateHistoricalTestResult(`
`31`	`31`	`if (keypather.get(test, 'build.stop') !== jesusBirthday) {`
`32`	`32`	`if (keypather.get(test, 'build.failed') \|\| keypather.get(test, 'application.exitCode') > 0) {`
`33`	`33`	`test.testState = FAILED;`
	`34`	`+ return;`
`34`	`35`	`} else if (keypather.get(test,'application.exitCode') === 0 && keypather.get(test,'application.stop') !== jesusBirthday) {`
`35`	`36`	`test.testState = PASSED;`
	`37`	`+ return;`
`36`	`38`	`}`
`37`	`39`	`}`
`38`	`40`	`});`