adding filter empty-string env values into bodyValidations flow

Author: cflynn07

lib/routes/instances/index.js

@@ -75,8 +75,12 @@ var bodyValidations = flow.series(
   ),
   mw.body('env').require()
     .then(
-      mw.body('env').array()
-        .validate(validations.isArrayOf('string')),
+      mw.body('env').array(),
+      mw.body('env').mapValues(function (envArr) {
+        return envArr.filter(function (val) {
+          return !(/^\s*$/.test(val));
+        });
+      }),
       mw.body('env').each(
         function (env, req, eachReq, res, next) {
           eachReq.env = env;
@@ -182,22 +186,6 @@ var removeInstanceContainer = // TODO: this has a lot of overlap with instance s
           }));
   };
 
-/**
- * Remove any empty/whitespace-only env values
- * @param {array} req.body.env
- */
-var instanceTransformEnvs = flow.series(
-  mw.body('env').require()
-    .then(
-      mw.body('env').array(),
-      mw.body('env').mapValues(function (envArr) {
-        return envArr.filter(function (val) {
-          return !(/^\s*$/.test(val));
-        });
-      })
-    )
-);
-
 /** Get's the list of instances to be displayed to the user.  This should contain all of the
  *  instances owned by the owner, as well as those owned by groups (s)he is part of
  *  @event GET rest/instances
@@ -227,7 +215,6 @@ app.get('/instances/',
 app.post('/instances/',
   mw.body('build').require().validate(validations.isObjectId),
   mw.body('name', 'owner', 'env', 'parent', 'build').pick(),
-  instanceTransformEnvs,
   // validate body types
   mw.body('owner.github').require()
     .then(
@@ -438,7 +425,6 @@ app.patch('/instances/:id',
     .then(
       mw.body().unset('build')),
   mw.body({ or: ['public', 'name', 'build', 'env']}).require().pick(),
-  instanceTransformEnvs,
   bodyValidations,
   mw.body({ or: ['build', 'name'] }).require()
     .then(