Skip to content

Commit 092ecf9

Browse files
committed
Remove Subreddits.search_by_topic method
1 parent 98df767 commit 092ecf9

5 files changed

Lines changed: 2 additions & 188 deletions

File tree

CHANGES.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ Unreleased
3030
- Remove ``Redditor.gildings`` method.
3131
- Remove ``Subreddit.mod.inbox``, ``Subreddit.mod.unread``, and
3232
``Subreddit.mod.stream.unread`` methods.
33+
- Remove ``Subreddits.search_by_topic`` method.
3334
- Remove ``Subreddits.gold`` method.
3435
- Remove :class:`.Reddit` keyword argument ``token_manager`` and all associated token
3536
managers.
@@ -1051,8 +1052,7 @@ as described below:
10511052

10521053
**Added**
10531054

1054-
- :meth:`.Subreddits.search_by_topic` to search subreddits by topic. (see:
1055-
https://www.reddit.com/dev/api/#GET_api_subreddits_by_topic).
1055+
- ``Subreddits.search_by_topic`` to search subreddits by topic.
10561056
- :meth:`.LiveHelper.__call__` to provide interface to
10571057
``praw.models.LiveThread.__init__``.
10581058
- :class:`.SubredditFilters` to work with filters for special subreddits, like

praw/endpoints.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@
177177
"subreddit_filter_list": "api/filter/user/{user}/f/{special}",
178178
"subreddit_settings": "r/{subreddit}/about/edit/",
179179
"subreddit_stylesheet": "r/{subreddit}/api/subreddit_stylesheet/",
180-
"subreddits_by_topic": "api/subreddits_by_topic",
181180
"subreddits_default": "subreddits/default/",
182181
"subreddits_name_search": "api/search_reddit_names/",
183182
"subreddits_new": "subreddits/new/",

praw/models/subreddits.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,6 @@ def search_by_name(
121121
)
122122
return [self._reddit.subreddit(x) for x in result["names"]]
123123

124-
def search_by_topic(self, query: str) -> list[praw.models.Subreddit]:
125-
"""Return list of Subreddits whose topics match ``query``.
126-
127-
:param query: Search for subreddits relevant to the search topic.
128-
129-
.. note::
130-
131-
As of 09/01/2020, this endpoint always returns 404.
132-
133-
"""
134-
result = self._reddit.get(API_PATH["subreddits_by_topic"], params={"query": query})
135-
return [self._reddit.subreddit(x["name"]) for x in result if x.get("name")]
136-
137124
def stream(self, **stream_options: str | int | dict[str, str]) -> Iterator[praw.models.Subreddit]:
138125
"""Yield new subreddits as they are created.
139126

tests/integration/cassettes/TestSubreddits.test_search_by_topic.json

Lines changed: 0 additions & 162 deletions
This file was deleted.

tests/integration/models/test_subreddits.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,6 @@ def test_search_by_name(self, reddit):
5858
assert len(subreddits) > 1
5959
assert all(isinstance(x, Subreddit) for x in subreddits)
6060

61-
def test_search_by_topic(self, reddit):
62-
subreddits = reddit.subreddits.search_by_topic("python")
63-
assert isinstance(subreddits, list)
64-
assert len(subreddits) > 1
65-
assert all(isinstance(x, Subreddit) for x in subreddits)
66-
67-
subreddits = reddit.subreddits.search_by_topic("xvfx2741r")
68-
assert isinstance(subreddits, list)
69-
assert len(subreddits) == 0
70-
7161
def test_stream(self, reddit):
7262
generator = reddit.subreddits.stream()
7363
for _i in range(101):

0 commit comments

Comments
 (0)