Merge pull request #70 from ClickHouse/ncb/remove-asserts

bharatnc · vitlibar · commit b7fa91bb0aec · 2026-02-09T19:14:39.000+01:00
remove debug table validation checks (cherry picked from commit 210f686)
diff --git a/cpp/src/arrow/table.cc b/cpp/src/arrow/table.cc
@@ -654,7 +654,6 @@ TableBatchReader::TableBatchReader(const Table& table)
   for (int i = 0; i < table.num_columns(); ++i) {
     column_data_[i] = table.column(i).get();
   }
-  DCHECK(table_.Validate().ok());
 }
 
 TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
@@ -668,7 +667,6 @@ TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
   for (int i = 0; i < owned_table_->num_columns(); ++i) {
     column_data_[i] = owned_table_->column(i).get();
   }
-  DCHECK(table_.Validate().ok());
 }
 
 std::shared_ptr<Schema> TableBatchReader::schema() const { return table_.schema(); }

Original file line number	Diff line number	Diff line change
`@@ -654,7 +654,6 @@ TableBatchReader::TableBatchReader(const Table& table)`
`654`	`654`	`for (int i = 0; i < table.num_columns(); ++i) {`
`655`	`655`	`column_data_[i] = table.column(i).get();`
`656`	`656`	`}`
`657`		`- DCHECK(table_.Validate().ok());`
`658`	`657`	`}`
`659`	`658`
`660`	`659`	`TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)`
`@@ -668,7 +667,6 @@ TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)`
`668`	`667`	`for (int i = 0; i < owned_table_->num_columns(); ++i) {`
`669`	`668`	`column_data_[i] = owned_table_->column(i).get();`
`670`	`669`	`}`
`671`		`- DCHECK(table_.Validate().ok());`
`672`	`670`	`}`
`673`	`671`
`674`	`672`	`std::shared_ptr<Schema> TableBatchReader::schema() const { return table_.schema(); }`