Skip to content

Commit f768e04

Browse files
committed
Add VK_COLOR_SPACE_DISPLAY_P3_LINEAR_EXT to FP16 surface
VK_COLOR_SPACE_DISPLAY_P3_LINEAR_EXT is not enabled on any VkFormat. This means ANGLE on Vulkan is not exposing EGL_EXT_gl_colorspace_display_p3_linear EGL colorspace, because ANGLE's query of VK_COLOR_SPACE_DISPLAY_P3_LINEAR_EXT vulkan color space returns nothing. This causes TextureViewTest that relies on EGL_EXT_gl_colorspace_display_p3_linear color space support to fail on ANGLE. To fix it, enable the VK_COLOR_SPACE_DISPLAY_P3_LINEAR_EXT color space on VK_FORMAT_R16G16B16A16_SFLOAT VkFormat first. Test: atest --verbose CtsViewTestCases:android.view.cts.TextureViewTest Bug: b/322044839 Change-Id: I95b6b425aef4b7870797e406dce59f596f1f50c3
1 parent d3ff521 commit f768e04

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

vulkan/libvulkan/swapchain.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
#include "vulkan/vulkan_core.h"
1718
#define ATRACE_TAG ATRACE_TAG_GRAPHICS
1819

1920
#include <aidl/android/hardware/graphics/common/Dataspace.h>
@@ -789,6 +790,9 @@ VkResult GetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice pdev,
789790
all_formats.emplace_back(
790791
VkSurfaceFormatKHR{VK_FORMAT_R16G16B16A16_SFLOAT,
791792
VK_COLOR_SPACE_DISPLAY_P3_NONLINEAR_EXT});
793+
all_formats.emplace_back(
794+
VkSurfaceFormatKHR{VK_FORMAT_R16G16B16A16_SFLOAT,
795+
VK_COLOR_SPACE_DISPLAY_P3_LINEAR_EXT});
792796
}
793797
}
794798

0 commit comments

Comments
 (0)