Skip to content

Commit eb5f59f

Browse files
Steven Morelandandroid-build-merge-worker-robot
authored andcommitted
Merge "Revert^4 "remove libbinder_ndk_helper_headers"" into main am: a574447
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3248548 Change-Id: I276d4ad35289b67ae5903b127486a5dfd2d310ba Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2 parents 97eba08 + a574447 commit eb5f59f

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

libs/binder/ndk/Android.bp

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -230,12 +230,24 @@ cc_library_headers {
230230
},
231231
apex_available: [
232232
"//apex_available:platform",
233+
"//apex_available:anyapex",
233234
"com.android.media",
234235
"com.android.media.swcodec",
235236
],
236237
min_sdk_version: "29",
237238
}
238239

240+
// TODO: if you try to export libbinder_headers_platform_shared from libbinder_ndk.ndk, it will
241+
// not select the NDK variant of libbinder_headers_platform_shared and instead, it will error
242+
// that the NDK can't depend on glibc C++.
243+
cc_library_headers {
244+
name: "libbinder_headers_platform_shared_ndk",
245+
export_include_dirs: ["include_cpp"],
246+
sdk_version: "29",
247+
min_sdk_version: "29",
248+
visibility: [":__subpackages__"],
249+
}
250+
239251
ndk_headers {
240252
name: "libbinder_ndk_headers",
241253
from: "include_ndk/android",
@@ -246,26 +258,14 @@ ndk_headers {
246258
license: "NOTICE",
247259
}
248260

249-
// TODO(b/160624671): package with the aidl compiler
250-
ndk_headers {
251-
name: "libbinder_ndk_helper_headers",
252-
from: "include_cpp/android",
253-
to: "android",
254-
srcs: [
255-
"include_cpp/android/*.h",
256-
],
257-
license: "NOTICE",
258-
// These are intentionally not C. It's a mistake that they're in the NDK.
259-
// See the bug above.
260-
skip_verification: true,
261-
}
261+
// include_cpp are packaged in development/build/sdk.atree with the AIDL compiler
262262

263263
ndk_library {
264264
name: "libbinder_ndk",
265265
symbol_file: "libbinder_ndk.map.txt",
266266
first_version: "29",
267267
export_header_libs: [
268-
"libbinder_ndk_headers",
269-
"libbinder_ndk_helper_headers",
268+
// used to be part of the NDK, platform things depend on it
269+
"libbinder_headers_platform_shared_ndk",
270270
],
271271
}

0 commit comments

Comments
 (0)