Skip to content

Commit e08f9f0

Browse files
prabirmspAndroid (Google) Code Review
authored andcommitted
Revert "InputTracer: Ensure 0 coordinate values are traced"
This reverts commit 0744642. Reason for revert: While writing unit tests for this class, I realized that there is a bug in this implementation. Will re-land with the test. Change-Id: I2f91d97f48ebc42ba9830924f7b1bb3e58b7bce8
1 parent 0744642 commit e08f9f0

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

services/inputflinger/dispatcher/trace/AndroidInputEventProtoConverter.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616

1717
#include "AndroidInputEventProtoConverter.h"
1818

19-
#include <android/input.h>
2019
#include <android-base/logging.h>
21-
#include <input/Input.h>
2220
#include <perfetto/trace/android/android_input_event.pbzero.h>
2321

2422
namespace android::inputdispatcher::trace {
@@ -69,12 +67,6 @@ void AndroidInputEventProtoConverter::toProtoMotionEvent(const TracedMotionEvent
6967

7068
const auto& coords = event.pointerCoords[i];
7169
auto bits = BitSet64(coords.bits);
72-
if (isFromSource(event.source, AINPUT_SOURCE_CLASS_POINTER)) {
73-
// Always include the X and Y axes for pointer events, since the
74-
// bits will not be marked if the value is 0.
75-
bits.markBit(AMOTION_EVENT_AXIS_X);
76-
bits.markBit(AMOTION_EVENT_AXIS_Y);
77-
}
7870
for (int32_t axisIndex = 0; !bits.isEmpty(); axisIndex++) {
7971
const auto axis = bits.clearFirstMarkedBit();
8072
auto axisEntry = pointer->add_axis_value();

0 commit comments

Comments
 (0)