Skip to content

Commit e03471a

Browse files
Justin LanninAndroid (Google) Code Review
authored andcommitted
Merge "ASM: Add required AppOp lookup to custom sensors for all permissions." into main
2 parents 1d038d4 + 0980aa8 commit e03471a

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

libs/sensor/Sensor.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,18 @@ Sensor::Sensor(struct sensor_t const& hwSensor, const uuid_t& uuid, int halVersi
306306
}
307307
if (halVersion > SENSORS_DEVICE_API_VERSION_1_0 && hwSensor.requiredPermission) {
308308
mRequiredPermission = hwSensor.requiredPermission;
309-
if (!strcmp(mRequiredPermission, SENSOR_PERMISSION_BODY_SENSORS)) {
309+
bool requiresBodySensorPermission =
310+
!strcmp(mRequiredPermission, SENSOR_PERMISSION_BODY_SENSORS);
311+
if (android::permission::flags::replace_body_sensor_permission_enabled()) {
312+
if (requiresBodySensorPermission) {
313+
ALOGE("Sensor %s using deprecated Body Sensor permission", mName.c_str());
314+
}
315+
316+
AppOpsManager appOps;
317+
// Lookup to see if an AppOp exists for the permission. If none
318+
// does, the default value of -1 is used.
319+
mRequiredAppOp = appOps.permissionToOpCode(String16(mRequiredPermission));
320+
} else if (requiresBodySensorPermission) {
310321
AppOpsManager appOps;
311322
mRequiredAppOp = appOps.permissionToOpCode(String16(SENSOR_PERMISSION_BODY_SENSORS));
312323
}

0 commit comments

Comments
 (0)