Skip to content

Commit d112b86

Browse files
committed
Mark @FlaggedApi flags as exported
An aconfig flag that is used together with @FlaggedApi must be marked as `is_exported: true` to guarantee that the auto-generated lookup code checks the actual flag value (instead of using a hard-coded value set at compile time). This is important when the API is called across aconfig container boundaries (e.g. a mainline module calling code on the system partition). Mark all non-exported flags used with @FlaggedApi as exported. The "all @FlaggedApi flags are exported" invariant should be checked at build time; this will be added in future CLs. Bug: 378061535 Test: treehugger Flag: EXEMPT can't flag changes to flag declarations Change-Id: Id69176ae7dd29c0dcf9cbeaf9979028020c3a9f3
1 parent d3ca472 commit d112b86

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

services/surfaceflinger/surfaceflinger_flags_new.aconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ flag {
3131
description: "New SDK Surface#setFrameRate API and Surface.FrameRateParams for Android 16"
3232
bug: "356987016"
3333
is_fixed_read_only: true
34+
is_exported: true
3435
} # arr_setframerate_api
3536

3637
flag {
@@ -39,6 +40,7 @@ flag {
3940
description: "New SDK SurfaceControl.Transaction#setFrameRate API for Android 16"
4041
bug: "356987016"
4142
is_fixed_read_only: true
43+
is_exported: true
4244
} # arr_surfacecontrol_setframerate_api
4345

4446
flag {

0 commit comments

Comments
 (0)