Skip to content

Commit cd46f38

Browse files
Steven MorelandAndroid (Google) Code Review
authored andcommitted
Merge "libbinder: better object logs" into main
2 parents 31bb4f9 + 3b685aa commit cd46f38

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

libs/binder/Parcel.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ static void acquire_object(const sp<ProcessState>& proc, const flat_binder_objec
180180
}
181181
}
182182

183-
ALOGD("Invalid object type 0x%08x", obj.hdr.type);
183+
ALOGE("Invalid object type 0x%08x to acquire", obj.hdr.type);
184184
}
185185

186186
static void release_object(const sp<ProcessState>& proc, const flat_binder_object& obj,
@@ -210,7 +210,7 @@ static void release_object(const sp<ProcessState>& proc, const flat_binder_objec
210210
}
211211
}
212212

213-
ALOGE("Invalid object type 0x%08x", obj.hdr.type);
213+
ALOGE("Invalid object type 0x%08x to release", obj.hdr.type);
214214
}
215215
#endif // BINDER_WITH_KERNEL_IPC
216216

@@ -1849,7 +1849,10 @@ status_t Parcel::validateReadData(size_t upperBound) const
18491849
if (mDataPos < kernelFields->mObjects[nextObject] + sizeof(flat_binder_object)) {
18501850
// Requested info overlaps with an object
18511851
if (!mServiceFuzzing) {
1852-
ALOGE("Attempt to read from protected data in Parcel %p", this);
1852+
ALOGE("Attempt to read or write from protected data in Parcel %p. pos: "
1853+
"%zu, nextObject: %zu, object offset: %llu, object size: %zu",
1854+
this, mDataPos, nextObject, kernelFields->mObjects[nextObject],
1855+
sizeof(flat_binder_object));
18531856
}
18541857
return PERMISSION_DENIED;
18551858
}

0 commit comments

Comments
 (0)