Cleanup GraphicsEnv::setAngleInfo()

Cleanup some minor nits and performance issues in
GraphicsEnv::setAngleInfo():

1. Make the paramater `eglFeatures` a reference.
   * This avoids the copy of the std::vector that's currently done every
   function call.
2. Remove `std::move()` calls on `const` values.
   * std::move() has no effect on const values, resulting in a copy
     anyway.

Bug: 372694741
Test: CQ
Change-Id: Id774e8c5aa06b966d04213251c195055e271687b

Author: timvpGoogle

libs/graphicsenv/GraphicsEnv.cpp

@@ -596,7 +596,7 @@ bool GraphicsEnv::shouldUseAngle() {
 // If path is set to nonempty and shouldUseNativeDriver is true, ANGLE will be used regardless.
 void GraphicsEnv::setAngleInfo(const std::string& path, const bool shouldUseNativeDriver,
                                const std::string& packageName,
-                               const std::vector<std::string> eglFeatures) {
+                               const std::vector<std::string>& eglFeatures) {
     if (mShouldUseAngle) {
         // ANGLE is already set up for this application process, even if the application
         // needs to switch from apk to system or vice versa, the application process must
@@ -606,11 +606,11 @@ void GraphicsEnv::setAngleInfo(const std::string& path, const bool shouldUseNati
         return;
     }
 
-    mAngleEglFeatures = std::move(eglFeatures);
+    mAngleEglFeatures = eglFeatures;
     ALOGV("setting ANGLE path to '%s'", path.c_str());
-    mAnglePath = std::move(path);
+    mAnglePath = path;
     ALOGV("setting app package name to '%s'", packageName.c_str());
-    mPackageName = std::move(packageName);
+    mPackageName = packageName;
     if (mAnglePath == "system") {
         mShouldUseSystemAngle = true;
     }

libs/graphicsenv/include/graphicsenv/GraphicsEnv.h

@@ -114,7 +114,7 @@ class GraphicsEnv {
     // If shouldUseNativeDriver is true, it means native GLES drivers must be used for the process.
     // If path is set to nonempty and shouldUseNativeDriver is true, ANGLE will be used regardless.
     void setAngleInfo(const std::string& path, const bool shouldUseNativeDriver,
-                      const std::string& packageName, const std::vector<std::string> eglFeatures);
+                      const std::string& packageName, const std::vector<std::string>& eglFeatures);
     // Get the ANGLE driver namespace.
     android_namespace_t* getAngleNamespace();
     // Get the app package name.