Skip to content

Commit c7b95f6

Browse files
ericsum26Android (Google) Code Review
authored andcommitted
Merge "Remove mInvalidatedCachedSetAges from Flattener." into main
2 parents 4ef6d54 + adcc7ba commit c7b95f6

2 files changed

Lines changed: 0 additions & 15 deletions

File tree

services/surfaceflinger/CompositionEngine/include/compositionengine/impl/planner/Flattener.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ class Flattener {
253253
std::unordered_map<size_t, size_t> mFinalLayerCounts;
254254
size_t mCachedSetCreationCount = 0;
255255
size_t mCachedSetCreationCost = 0;
256-
std::unordered_map<size_t, size_t> mInvalidatedCachedSetAges;
257256
};
258257

259258
} // namespace compositionengine::impl::planner

services/surfaceflinger/CompositionEngine/src/planner/Flattener.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -243,17 +243,9 @@ void Flattener::resetActivities(NonBufferHash hash, time_point now) {
243243

244244
mCurrentGeometry = hash;
245245
mLastGeometryUpdate = now;
246-
247-
for (const CachedSet& cachedSet : mLayers) {
248-
if (cachedSet.getLayerCount() > 1) {
249-
++mInvalidatedCachedSetAges[cachedSet.getAge()];
250-
}
251-
}
252-
253246
mLayers.clear();
254247

255248
if (mNewCachedSet) {
256-
++mInvalidatedCachedSetAges[mNewCachedSet->getAge()];
257249
mNewCachedSet = std::nullopt;
258250
}
259251
}
@@ -312,7 +304,6 @@ bool Flattener::mergeWithCachedSets(const std::vector<const LayerState*>& layers
312304
mNewCachedSet->getFirstLayer().getState()->getId() == (*incomingLayerIter)->getId()) {
313305
if (mNewCachedSet->hasBufferUpdate()) {
314306
ALOGV("[%s] Dropping new cached set", __func__);
315-
++mInvalidatedCachedSetAges[0];
316307
mNewCachedSet = std::nullopt;
317308
} else if (mNewCachedSet->hasReadyBuffer()) {
318309
ALOGV("[%s] Found ready buffer", __func__);
@@ -339,10 +330,6 @@ bool Flattener::mergeWithCachedSets(const std::vector<const LayerState*>& layers
339330
};
340331
++incomingLayerIter;
341332
}
342-
343-
if (currentLayerIter->getLayerCount() > 1) {
344-
++mInvalidatedCachedSetAges[currentLayerIter->getAge()];
345-
}
346333
++currentLayerIter;
347334

348335
skipCount -= layerCount;
@@ -382,7 +369,6 @@ bool Flattener::mergeWithCachedSets(const std::vector<const LayerState*>& layers
382369
priorBlurLayer = currentLayerIter->getBlurLayer();
383370
} else if (currentLayerIter->getLayerCount() > 1) {
384371
// Break the current layer into its constituent layers
385-
++mInvalidatedCachedSetAges[currentLayerIter->getAge()];
386372
for (CachedSet& layer : currentLayerIter->decompose()) {
387373
bool disableBlur =
388374
priorBlurLayer && priorBlurLayer == (*incomingLayerIter)->getOutputLayer();

0 commit comments

Comments
 (0)