Skip to content

Commit c6d1ada

Browse files
author
Ted Bauer
committed
Remove device-side printflags from dumpstate
To report device flag values, we are using aflags list, which shows up in the bugreport under ACONFIG FLAGS DUMP. Remove to avoid redundant information. Change-Id: Ie7d1676f60cbbbf4d190c0e46da0649da35d943b Test: m Bug: 388777619
1 parent 12a57e3 commit c6d1ada

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

cmds/dumpstate/dumpstate.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ void add_mountinfo();
194194
#define CGROUPFS_DIR "/sys/fs/cgroup"
195195
#define SDK_EXT_INFO "/apex/com.android.sdkext/bin/derive_sdk"
196196
#define DROPBOX_DIR "/data/system/dropbox"
197-
#define PRINT_FLAGS "/system/bin/printflags"
198197
#define UWB_LOG_DIR "/data/misc/apexdata/com.android.uwb/log"
199198

200199
// TODO(narayan): Since this information has to be kept in sync
@@ -1816,12 +1815,8 @@ Dumpstate::RunStatus Dumpstate::dumpstate() {
18161815
DumpFile("PRODUCT BUILD-TIME RELEASE FLAGS", "/product/etc/build_flags.json");
18171816
DumpFile("VENDOR BUILD-TIME RELEASE FLAGS", "/vendor/etc/build_flags.json");
18181817

1819-
RunCommand("ACONFIG FLAGS", {PRINT_FLAGS},
1820-
CommandOptions::WithTimeout(10).Always().DropRoot().Build());
18211818
RunCommand("ACONFIG FLAGS DUMP", {AFLAGS, "list"},
18221819
CommandOptions::WithTimeout(10).Always().AsRootIfAvailable().Build());
1823-
RunCommand("WHICH ACONFIG FLAG STORAGE", {AFLAGS, "which-backing"},
1824-
CommandOptions::WithTimeout(10).Always().AsRootIfAvailable().Build());
18251820

18261821
RunCommand("STORAGED IO INFO", {"storaged", "-u", "-p"});
18271822

0 commit comments

Comments
 (0)