Merge "binder: fix coverity warnings" into main am: 2aac811

Steven Moreland · android-build-merge-worker-robot · commit bb8e002650f8 · 2024-02-07T23:29:08.000Z
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2951649 Change-Id: Idcd7eb9b81ae80696d10c83db1efef5ef3079d64 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
diff --git a/libs/binder/ProcessState.cpp b/libs/binder/ProcessState.cpp
@@ -492,6 +492,7 @@ bool ProcessState::isDriverFeatureEnabled(const DriverFeature feature) {
     if (read(fd, &on, sizeof(on)) == -1) {
         ALOGE("%s: error reading to %s: %s", __func__,
                  names[static_cast<int>(feature)], strerror(errno));
+        close(fd);
         return false;
     }
     close(fd);

Original file line number	Diff line number	Diff line change
`@@ -492,6 +492,7 @@ bool ProcessState::isDriverFeatureEnabled(const DriverFeature feature) {`
`492`	`492`	`if (read(fd, &on, sizeof(on)) == -1) {`
`493`	`493`	`ALOGE("%s: error reading to %s: %s", __func__,`
`494`	`494`	`names[static_cast<int>(feature)], strerror(errno));`
	`495`	`+ close(fd);`
`495`	`496`	`return false;`
`496`	`497`	`}`
`497`	`498`	`close(fd);`