Harden construction sites of android::StrongPointer.

Anton Ivanov · Anton Ivanov · commit b3ff767ca89d · 2025-02-14T12:03:11.000-08:00
Bug: 393217449
Test: presubmit
Flag: EXEMPT_refactor
Change-Id: I36bc3241010fd0ffd658dc0a7fc9f028c1118372
Ignore-AOSP-First: Will merge to AOSP after bug is fixed.
diff --git a/libs/binder/include/binder/SafeInterface.h b/libs/binder/include/binder/SafeInterface.h
@@ -79,7 +79,7 @@ class LIBBINDER_EXPORTED ParcelHandler {
     template <typename T>
     typename std::enable_if<std::is_base_of<Flattenable<T>, T>::value, status_t>::type read(
             const Parcel& parcel, sp<T>* t) const {
-        *t = new T{};
+        *t = sp<T>::make();
         return callParcel("read(sp<Flattenable>)", [&]() { return parcel.read(*(t->get())); });
     }
     template <typename T>

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ class LIBBINDER_EXPORTED ParcelHandler {`
`79`	`79`	`template <typename T>`
`80`	`80`	`typename std::enable_if<std::is_base_of<Flattenable<T>, T>::value, status_t>::type read(`
`81`	`81`	`const Parcel& parcel, sp<T>* t) const {`
`82`		`- *t = new T{};`
	`82`	`+ *t = sp<T>::make();`
`83`	`83`	`return callParcel("read(sp<Flattenable>)", [&]() { return parcel.read(*(t->get())); });`
`84`	`84`	`}`
`85`	`85`	`template <typename T>`