Skip to content

Commit b3191a4

Browse files
tyiu-googleAndroid (Google) Code Review
authored andcommitted
Merge "RESTRICT AUTOMERGE: Fix HMAC Compare time attack" into tm-dev
2 parents ac3b732 + ca8d670 commit b3191a4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

services/inputflinger/dispatcher/InputDispatcher.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include <ftl/enum.h>
2828
#include <gui/SurfaceComposerClient.h>
2929
#include <input/InputDevice.h>
30+
#include <openssl/mem.h>
3031
#include <powermanager/PowerManager.h>
3132
#include <unistd.h>
3233
#include <utils/Trace.h>
@@ -4422,7 +4423,7 @@ std::unique_ptr<VerifiedInputEvent> InputDispatcher::verifyInputEvent(const Inpu
44224423
if (calculatedHmac == INVALID_HMAC) {
44234424
return nullptr;
44244425
}
4425-
if (calculatedHmac != event.getHmac()) {
4426+
if (0 != CRYPTO_memcmp(calculatedHmac.data(), event.getHmac().data(), calculatedHmac.size())) {
44264427
return nullptr;
44274428
}
44284429
return result;

0 commit comments

Comments
 (0)