Skip to content

Commit 9a3ad9b

Browse files
Rachel LeeAndroid (Google) Code Review
authored andcommitted
Merge "Revert "Define new ASurfaceTransaction_setFrameRateParams API"" into main
2 parents 2de26dd + c0db0c9 commit 9a3ad9b

1 file changed

Lines changed: 0 additions & 63 deletions

File tree

include/android/surface_control.h

Lines changed: 0 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -780,69 +780,6 @@ void ASurfaceTransaction_setFrameRateWithChangeStrategy(ASurfaceTransaction* _No
780780
int8_t changeFrameRateStrategy)
781781
__INTRODUCED_IN(31);
782782

783-
/**
784-
* Sets the intended frame rate for the given \a surface_control.
785-
*
786-
* On devices that are capable of running the display at different frame rates,
787-
* the system may choose a display refresh rate to better match this surface's frame
788-
* rate. Usage of this API won't introduce frame rate throttling, or affect other
789-
* aspects of the application's frame production pipeline. However, because the system
790-
* may change the display refresh rate, calls to this function may result in changes
791-
* to Choreographer callback timings, and changes to the time interval at which the
792-
* system releases buffers back to the application.
793-
*
794-
* You can register for changes in the refresh rate using
795-
* \a AChoreographer_registerRefreshRateCallback.
796-
*
797-
* See ASurfaceTransaction_clearFrameRate().
798-
*
799-
* Available since API level 36.
800-
*
801-
* \param desiredMinRate The desired minimum frame rate (inclusive) for the surface, specifying that
802-
* the surface prefers the device render rate to be at least `desiredMinRate`.
803-
*
804-
* <p>Set `desiredMinRate` = `desiredMaxRate` to indicate the surface prefers an exact frame rate.
805-
*
806-
* <p>Set `desiredMinRate` = 0 to indicate the surface has no preference
807-
* and any frame rate is acceptable.
808-
*
809-
* <p>The value should be greater than or equal to 0.
810-
*
811-
* \param desiredMaxRate The desired maximum frame rate (inclusive) for the surface, specifying that
812-
* the surface prefers the device render rate to be at most `desiredMaxRate`.
813-
*
814-
* <p>Set `desiredMaxRate` = `desiredMinRate` to indicate the surface prefers an exact frame rate.
815-
*
816-
* <p>Set `desiredMaxRate` = positive infinity to indicate the surface has no preference
817-
* and any frame rate is acceptable.
818-
*
819-
* <p>The value should be greater than or equal to `desiredMinRate`.
820-
*
821-
* \param fixedSourceRate The "fixed source" frame rate of the surface if the content has an
822-
* inherently fixed frame rate, e.g. a video that has a specific frame rate.
823-
*
824-
* <p>When the frame rate chosen for the surface is the `fixedSourceRate` or a
825-
* multiple, the surface can render without frame pulldown, for optimal smoothness. For
826-
* example, a 30 fps video (`fixedSourceRate`=30) renders just as smoothly on 30 fps,
827-
* 60 fps, 90 fps, 120 fps, and so on.
828-
*
829-
* <p>Setting the fixed source rate can also be used together with a desired
830-
* frame rate min and max via setting `desiredMinRate` and `desiredMaxRate`. This still
831-
* means the surface's content has a fixed frame rate of `fixedSourceRate`, but additionally
832-
* specifies the preference to be in the range [`desiredMinRate`, `desiredMaxRate`]. For example, an
833-
* app might want to specify there is 30 fps video (`fixedSourceRate`=30) as well as a smooth
834-
* animation on the same surface which looks good when drawing within a frame rate range such as
835-
* [`desiredMinRate`, `desiredMaxRate`] = [60,120].
836-
*
837-
* \param changeFrameRateStrategy Whether display refresh rate transitions caused by this surface
838-
* should be seamless. A seamless transition is one that doesn't have any visual interruptions, such
839-
* as a black screen for a second or two.
840-
*/
841-
void ASurfaceTransaction_setFrameRateParams(
842-
ASurfaceTransaction* _Nonnull transaction, ASurfaceControl* _Nonnull surface_control,
843-
float desiredMinRate, float desiredMaxRate, float fixedSourceRate,
844-
ANativeWindow_ChangeFrameRateStrategy changeFrameRateStrategy) __INTRODUCED_IN(36);
845-
846783
/**
847784
* Clears the frame rate which is set for \a surface_control.
848785
*

0 commit comments

Comments
 (0)