Skip to content

Commit 97fe7cd

Browse files
Remove ARpcDoubleRemoveProvider test because UB
This is undefined behavior (use-after-free) because the ABinderRpc_AccessorProvider is deleted with the first call to ABinderRpc_unregisterAccessorProvider! Test: none Bug: 369847529 Change-Id: I71ffe6e87d479ab998a8b1fe14c7f7216024417b
1 parent 8dd8927 commit 97fe7cd

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

libs/binder/tests/binderRpcTest.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1544,15 +1544,6 @@ TEST_F(BinderARpcNdk, ARpcNoDataNoInfoOnDeleteCallback) {
15441544
ABinderRpc_Accessor_delete(accessor);
15451545
}
15461546

1547-
TEST_F(BinderARpcNdk, ARpcDoubleRemoveProvider) {
1548-
ABinderRpc_AccessorProvider* provider =
1549-
ABinderRpc_registerAccessorProvider(getAccessor, kARpcSupportedServices,
1550-
kARpcNumSupportedServices, nullptr, nullptr);
1551-
ASSERT_NE(nullptr, provider);
1552-
ABinderRpc_unregisterAccessorProvider(provider);
1553-
EXPECT_DEATH(ABinderRpc_unregisterAccessorProvider(provider), " was already unregistered");
1554-
}
1555-
15561547
TEST_F(BinderARpcNdk, ARpcNullArgs_ConnectionInfo_new) {
15571548
sockaddr_storage addr;
15581549
EXPECT_EQ(nullptr, ABinderRpc_ConnectionInfo_new(reinterpret_cast<const sockaddr*>(&addr), 0));

0 commit comments

Comments
 (0)