KeyboardInputMapper_test: send UP in Process_SendsReadTime

HarryCutts · HarryCutts · commit 8e32b85a43f8 · 2025-02-28T16:36:10.000Z
This was sending two key downs, rather than a down and an up.

Test: atest --host \
      frameworks/native/services/inputflinger/tests/KeyboardInputMapper_test.cpp
Bug: 245989146
Flag: TEST_ONLY
Change-Id: Iea57303277766dcfbe8be7e2cd32d0e88e5059d3
diff --git a/services/inputflinger/tests/KeyboardInputMapper_test.cpp b/services/inputflinger/tests/KeyboardInputMapper_test.cpp
@@ -346,7 +346,7 @@ TEST_F(KeyboardInputMapperUnitTest, Process_SendsReadTime) {
     ASSERT_EQ(12, expectSingleKeyArg(argsList).readTime);
 
     // Key up
-    argsList = process(ARBITRARY_TIME, /*readTime=*/15, EV_KEY, KEY_HOME, 1);
+    argsList = process(ARBITRARY_TIME, /*readTime=*/15, EV_KEY, KEY_HOME, 0);
     ASSERT_EQ(15, expectSingleKeyArg(argsList).readTime);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ TEST_F(KeyboardInputMapperUnitTest, Process_SendsReadTime) {`
`346`	`346`	`ASSERT_EQ(12, expectSingleKeyArg(argsList).readTime);`
`347`	`347`
`348`	`348`	`// Key up`
`349`		`- argsList = process(ARBITRARY_TIME, /readTime=/15, EV_KEY, KEY_HOME, 1);`
	`349`	`+ argsList = process(ARBITRARY_TIME, /readTime=/15, EV_KEY, KEY_HOME, 0);`
`350`	`350`	`ASSERT_EQ(15, expectSingleKeyArg(argsList).readTime);`
`351`	`351`	`}`
`352`	`352`